]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
reset: eyeq: fix OF node leak
authorJohan Hovold <johan@kernel.org>
Tue, 8 Jul 2025 08:56:13 +0000 (10:56 +0200)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Wed, 27 Aug 2025 14:40:13 +0000 (16:40 +0200)
Make sure to drop the OF node reference taken when probing the auxiliary
device when the device is later unbound.

Fixes: 487b1b32e317 ("reset: eyeq: add platform driver")
Cc: Théo Lebrun <theo.lebrun@bootlin.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20250708085613.15823-1-johan@kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/reset/reset-eyeq.c

index 02d50041048b42921e3e511148cd29f215b5fc5e..2d3998368a1c5edb62509a3d3dff9283521d03df 100644 (file)
@@ -410,6 +410,13 @@ static int eqr_of_xlate_twocells(struct reset_controller_dev *rcdev,
        return eqr_of_xlate_internal(rcdev, reset_spec->args[0], reset_spec->args[1]);
 }
 
+static void eqr_of_node_put(void *_dev)
+{
+       struct device *dev = _dev;
+
+       of_node_put(dev->of_node);
+}
+
 static int eqr_probe(struct auxiliary_device *adev,
                     const struct auxiliary_device_id *id)
 {
@@ -428,6 +435,10 @@ static int eqr_probe(struct auxiliary_device *adev,
        if (!dev->of_node)
                return -ENODEV;
 
+       ret = devm_add_action_or_reset(dev, eqr_of_node_put, dev);
+       if (ret)
+               return ret;
+
        /*
         * Using our newfound OF node, we can get match data. We cannot use
         * device_get_match_data() because it does not match reused OF nodes.