]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
accel/ivpu: Fix deadlock in ivpu_ms_cleanup()
authorJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Tue, 25 Mar 2025 11:43:05 +0000 (12:43 +0100)
committerJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Mon, 31 Mar 2025 12:19:05 +0000 (14:19 +0200)
Fix deadlock in ivpu_ms_cleanup() by preventing runtime resume after
file_priv->ms_lock is acquired.

During a failure in runtime resume, a cold boot is executed, which
calls ivpu_ms_cleanup_all(). This function calls ivpu_ms_cleanup()
that acquires file_priv->ms_lock and causes the deadlock.

Fixes: cdfad4db7756 ("accel/ivpu: Add NPU profiling support")
Cc: stable@vger.kernel.org # v6.11+
Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
Reviewed-by: Lizhi Hou <lizhi.hou@amd.com>
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Link: https://lore.kernel.org/r/20250325114306.3740022-2-maciej.falkowski@linux.intel.com
drivers/accel/ivpu/ivpu_ms.c

index ffe7b10f8a767b9f67ec336a88adb217a2dd0169..eb485cf15ad64f85c02efaa7e3029d928f94134c 100644 (file)
@@ -4,6 +4,7 @@
  */
 
 #include <drm/drm_file.h>
+#include <linux/pm_runtime.h>
 
 #include "ivpu_drv.h"
 #include "ivpu_gem.h"
@@ -281,6 +282,9 @@ unlock:
 void ivpu_ms_cleanup(struct ivpu_file_priv *file_priv)
 {
        struct ivpu_ms_instance *ms, *tmp;
+       struct ivpu_device *vdev = file_priv->vdev;
+
+       pm_runtime_get_sync(vdev->drm.dev);
 
        mutex_lock(&file_priv->ms_lock);
 
@@ -293,6 +297,8 @@ void ivpu_ms_cleanup(struct ivpu_file_priv *file_priv)
                free_instance(file_priv, ms);
 
        mutex_unlock(&file_priv->ms_lock);
+
+       pm_runtime_put_autosuspend(vdev->drm.dev);
 }
 
 void ivpu_ms_cleanup_all(struct ivpu_device *vdev)