]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
sim: ppc: fix implicit enum conversion
authorMike Frysinger <vapier@gentoo.org>
Tue, 5 Dec 2023 04:40:05 +0000 (23:40 -0500)
committerMike Frysinger <vapier@gentoo.org>
Tue, 5 Dec 2023 04:41:31 +0000 (23:41 -0500)
This code tries to use attach_type enums as hw_phb_decode, and while
they're setup to have compatible values, the compiler doesn't like it
when the cast is missing.  So cast it explicitly and then use that.

sim/ppc/hw_phb.c:322:28: error:
implicit conversion from enumeration type 'attach_type'
(aka 'enum _attach_type') to different enumeration type
'hw_phb_decode' [-Werror,-Wenum-conversion]

sim/ppc/hw_phb.c

index a3c19264235114e517505a991ef91427e32366df..ec1119ee7d9bdb5019e3585260a9caea811983fd 100644 (file)
@@ -303,6 +303,7 @@ hw_phb_attach_address(device *me,
 {
   hw_phb_device *phb = device_data(me);
   phb_space *pci_space;
+  hw_phb_decode phb_type = (hw_phb_decode)type;
   /* sanity checks */
   if (space < 0 || space >= nr_hw_phb_spaces)
     device_error(me, "attach space (%d) specified by %s invalid",
@@ -312,14 +313,13 @@ hw_phb_attach_address(device *me,
       || addr < pci_space->my_base)
     device_error(me, "attach addr (0x%lx) specified by %s outside of bus address range",
                 (unsigned long)addr, device_path(client));
-  if ((hw_phb_decode)type != hw_phb_normal_decode
-      && (hw_phb_decode)type != hw_phb_subtractive_decode)
+  if (phb_type != hw_phb_normal_decode && phb_type != hw_phb_subtractive_decode)
     device_error(me, "attach type (%d) specified by %s invalid",
                 type, device_path(client));
   /* attach it to the relevent bus */
   DTRACE(phb, ("attach %s - %s %s:0x%lx (0x%lx bytes)\n",
               device_path(client),
-              hw_phb_decode_name(type),
+              hw_phb_decode_name(phb_type),
               pci_space->name,
               (unsigned long)addr,
               (unsigned long)nr_bytes));