]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: can: j1939: recover socket queue on CAN bus error during BAM transmission
authorOleksij Rempel <o.rempel@pengutronix.de>
Tue, 28 May 2024 07:06:48 +0000 (09:06 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 21 Jun 2024 08:50:17 +0000 (10:50 +0200)
Addresses an issue where a CAN bus error during a BAM transmission
could stall the socket queue, preventing further transmissions even
after the bus error is resolved. The fix activates the next queued
session after the error recovery, allowing communication to continue.

Fixes: 9d71dd0c70099 ("can: add support of SAE J1939 protocol")
Cc: stable@vger.kernel.org
Reported-by: Alexander Hölzl <alexander.hoelzl@gmx.net>
Tested-by: Alexander Hölzl <alexander.hoelzl@gmx.net>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/all/20240528070648.1947203-1-o.rempel@pengutronix.de
Cc: stable@vger.kernel.org
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/j1939/transport.c

index c6569f98d25144c99c60d7d7067634c9646d0f9f..4be73de5033cb77a237095164f32709d74e77a6a 100644 (file)
@@ -1696,6 +1696,8 @@ static int j1939_xtp_rx_rts_session_active(struct j1939_session *session,
 
                j1939_session_timers_cancel(session);
                j1939_session_cancel(session, J1939_XTP_ABORT_BUSY);
+               if (session->transmission)
+                       j1939_session_deactivate_activate_next(session);
 
                return -EBUSY;
        }