]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
config: Make local_name comparison faster
authorAki Tuomi <aki.tuomi@dovecot.fi>
Tue, 6 Mar 2018 08:31:51 +0000 (10:31 +0200)
committerVille Savolainen <ville.savolainen@dovecot.fi>
Thu, 15 Mar 2018 12:58:19 +0000 (14:58 +0200)
Based on patch by J. Nick Koston <nick@cpanel.net>

src/config/config-filter.c

index 2805e9dbe000d7301595243c067463f7ce7ddd90..058cba52d00ba03b1117d4142f01eca1980b08b2 100644 (file)
@@ -37,13 +37,14 @@ config_filter_match_local_name(const struct config_filter *mask,
 {
        /* Handle multiple names seperated by spaces in local_name
           * Ex: local_name "mail.domain.tld domain.tld mx.domain.tld" { ... } */
-       const char *const *local_name = t_strsplit_spaces(mask->local_name, " ");
-
-       for (; *local_name != NULL; local_name++) {
-               if (dns_match_wildcard(filter_local_name, *local_name) == 0)
+       const char *ptr, *local_name = mask->local_name;
+       while((ptr = strchr(local_name, ' ')) != NULL) {
+               if (dns_match_wildcard(filter_local_name,
+                   t_strdup_until(local_name, ptr)) == 0)
                        return TRUE;
+               local_name = ptr+1;
        }
-       return FALSE;
+       return dns_match_wildcard(filter_local_name, local_name) == 0;
 }
 
 static bool config_filter_match_rest(const struct config_filter *mask,