scsi: fnic: Fix indentation and remove unnecessary parenthesis

Fix indentation in fdls_disc.c to fix kernel test robot warnings.
Remove unnecessary parentheses to fix checkpatch check.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202502141403.1PcpwyJp-lkp@intel.com/
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202502141403.1PcpwyJp-lkp@intel.com/
Fixes: a63e78eb2b0f ("scsi: fnic: Add support for fabric based solicited requests and responses")
Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: Arun Easi <aeasi@cisco.com>
Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
Link: https://lore.kernel.org/r/20250225215013.4875-1-kartilak@cisco.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/fnic/fdls_disc.c b/drivers/scsi/fnic/fdls_disc.c
index d12caede89191ebb1fa767c20ab6e745bef2a7f9..ff9ba7cafc0197370a7e42811b7492cee914dfce 100644 (file)
--- a/drivers/scsi/fnic/fdls_disc.c
+++ b/drivers/scsi/fnic/fdls_disc.c
@@ -318,8 +318,8 @@ void fdls_schedule_oxid_free_retry_work(struct work_struct *work)
                        "Schedule oxid free. oxid idx: %d\n", idx);
 
                spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);
-       reclaim_entry = (struct reclaim_entry_s *)
-       kzalloc(sizeof(struct reclaim_entry_s), GFP_KERNEL);
+               reclaim_entry = (struct reclaim_entry_s *)
+                                               kzalloc(sizeof(struct reclaim_entry_s), GFP_KERNEL);
                spin_lock_irqsave(&fnic->fnic_lock, fnic->lock_flags);
 
                if (!reclaim_entry) {
@@ -338,7 +338,7 @@ void fdls_schedule_oxid_free_retry_work(struct work_struct *work)
                        /* unlikely scenario, free the allocated memory and continue */
                        kfree(reclaim_entry);
                }
-}
+       }
 
        spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);
 }
@@ -1563,9 +1563,9 @@ void fdls_send_fabric_logo(struct fnic_iport_s *iport)
 
        iport->fabric.flags &= ~FNIC_FDLS_FABRIC_ABORT_ISSUED;
 
-               FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
-                "0x%x: FDLS send fabric LOGO with oxid: 0x%x",
-                iport->fcid, oxid);
+       FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
+                    "0x%x: FDLS send fabric LOGO with oxid: 0x%x",
+                    iport->fcid, oxid);
 
        fnic_send_fcoe_frame(iport, frame, frame_size);
 
@@ -4655,13 +4655,13 @@ fnic_fdls_validate_and_get_frame_type(struct fnic_iport_s *iport,
        d_id = ntoh24(fchdr->fh_d_id);
 
        /* some common validation */
-               if (fdls_get_state(fabric) > FDLS_STATE_FABRIC_FLOGI) {
-                       if ((iport->fcid != d_id) || (!FNIC_FC_FRAME_CS_CTL(fchdr))) {
-                               FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
-                                                        "invalid frame received. Dropping frame");
-                               return -1;
-                       }
+       if (fdls_get_state(fabric) > FDLS_STATE_FABRIC_FLOGI) {
+               if (iport->fcid != d_id || (!FNIC_FC_FRAME_CS_CTL(fchdr))) {
+                       FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
+                                    "invalid frame received. Dropping frame");
+                       return -1;
                }
+       }
 
        /*  BLS ABTS response */
        if ((fchdr->fh_r_ctl == FC_RCTL_BA_ACC)
@@ -4678,7 +4678,7 @@ fnic_fdls_validate_and_get_frame_type(struct fnic_iport_s *iport,
                                        "Received unexpected ABTS RSP(oxid:0x%x) from 0x%x. Dropping frame",
                                        oxid, s_id);
                                return -1;
-       }
+               }
                        return FNIC_FABRIC_BLS_ABTS_RSP;
                } else if (fdls_is_oxid_fdmi_req(oxid)) {
                        return FNIC_FDMI_BLS_ABTS_RSP;