]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
um: Use swap() to make code cleaner
authorYang Guang <yang.guang5@zte.com.cn>
Fri, 5 Nov 2021 06:12:59 +0000 (14:12 +0800)
committerRichard Weinberger <richard@nod.at>
Tue, 21 Dec 2021 20:41:04 +0000 (21:41 +0100)
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/um/os-Linux/sigio.c

index 9e71794839e87778d0f90d12c4db9b4c18427761..37d60e72cf269cc230966164fc0490311b0f36f2 100644 (file)
@@ -3,6 +3,7 @@
  * Copyright (C) 2002 - 2008 Jeff Dike (jdike@{addtoit,linux.intel}.com)
  */
 
+#include <linux/minmax.h>
 #include <unistd.h>
 #include <errno.h>
 #include <fcntl.h>
@@ -50,7 +51,7 @@ static struct pollfds all_sigio_fds;
 
 static int write_sigio_thread(void *unused)
 {
-       struct pollfds *fds, tmp;
+       struct pollfds *fds;
        struct pollfd *p;
        int i, n, respond_fd;
        char c;
@@ -77,9 +78,7 @@ static int write_sigio_thread(void *unused)
                                               "write_sigio_thread : "
                                               "read on socket failed, "
                                               "err = %d\n", errno);
-                               tmp = current_poll;
-                               current_poll = next_poll;
-                               next_poll = tmp;
+                               swap(current_poll, next_poll);
                                respond_fd = sigio_private[1];
                        }
                        else {