]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
kconfig: remember the current choice while parsing the choice block
authorMasahiro Yamada <masahiroy@kernel.org>
Tue, 11 Jun 2024 17:55:13 +0000 (02:55 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Mon, 15 Jul 2024 16:08:36 +0000 (01:08 +0900)
Instead of the boolean flag, it will be more useful to remember the
current choice being parsed.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kconfig/parser.y

index 8adb2f70121ededc516d71fb88bcfbec472b3651..20538e1d3788fa912d1eb4fcb2f1312c8b10e46a 100644 (file)
@@ -28,9 +28,7 @@ static void zconf_error(const char *err, ...);
 static bool zconf_endtoken(const char *tokenname,
                           const char *expected_tokenname);
 
-struct menu *current_menu, *current_entry;
-
-static bool inside_choice = false;
+struct menu *current_menu, *current_entry, *current_choice;
 
 %}
 
@@ -147,7 +145,7 @@ config_entry_start: T_CONFIG nonconst_symbol T_EOL
 
 config_stmt: config_entry_start config_option_list
 {
-       if (inside_choice) {
+       if (current_choice) {
                if (!current_entry->prompt) {
                        fprintf(stderr, "%s:%d: error: choice member must have a prompt\n",
                                current_entry->filename, current_entry->lineno);
@@ -256,12 +254,12 @@ choice_entry: choice choice_option_list
 
        $$ = menu_add_menu();
 
-       inside_choice = true;
+       current_choice = current_entry;
 };
 
 choice_end: end
 {
-       inside_choice = false;
+       current_choice = NULL;
 
        if (zconf_endtoken($1, "choice")) {
                menu_end_menu();