]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
neighbour: Remove redundant assignment to err
authorYue Haibing <yuehaibing@huawei.com>
Tue, 24 Jun 2025 01:42:16 +0000 (09:42 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 25 Jun 2025 22:26:03 +0000 (15:26 -0700)
'err' has been checked against 0 in the if statement.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250624014216.3686659-1-yuehaibing@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/neighbour.c

index 85a5535de8ba2b7c340e580fadaf2a6eab1a85d5..8ad9898f8e42c491a3bc22a0c596526161bed205 100644 (file)
@@ -2055,10 +2055,8 @@ static int neigh_add(struct sk_buff *skb, struct nlmsghdr *nlh,
 
        err = __neigh_update(neigh, lladdr, ndm->ndm_state, flags,
                             NETLINK_CB(skb).portid, extack);
-       if (!err && ndm_flags & (NTF_USE | NTF_MANAGED)) {
+       if (!err && ndm_flags & (NTF_USE | NTF_MANAGED))
                neigh_event_send(neigh, NULL);
-               err = 0;
-       }
        neigh_release(neigh);
 out:
        return err;