regmap: place foo / 8 and foo % 8 closer to each other

On x86 the compiler (gcc (Debian 14.2.0-8) 14.2.0) may generate
a better code if it sees division and modulo goes together.

  Function                          old     new   delta
  __regmap_init                    3740    3732      -8
  Total: Before=31159, After=31151, chg -0.03%

clang (Debian clang version 18.1.8) on x86_64 still shows better code

  Function                          old     new   delta
  __regmap_init                    3582    3579      -3
  Total: Before=39854, After=39851, chg -0.01%

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20241121105838.4073659-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index d2944271022c6828dfe20712d8fa22cd90794f68..4f8ec8528e346d57119b92d649f9621cefbaaf01 100644 (file)
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -758,13 +758,13 @@ struct regmap *__regmap_init(struct device *dev,
                map->alloc_flags = GFP_KERNEL;
 
        map->reg_base = config->reg_base;
+       map->reg_shift = config->pad_bits % 8;
 
-       map->format.reg_bytes = BITS_TO_BYTES(config->reg_bits);
        map->format.pad_bytes = config->pad_bits / 8;
        map->format.reg_shift = config->reg_shift;
+       map->format.reg_bytes = BITS_TO_BYTES(config->reg_bits);
        map->format.val_bytes = BITS_TO_BYTES(config->val_bits);
        map->format.buf_size = BITS_TO_BYTES(config->reg_bits + config->val_bits + config->pad_bits);
-       map->reg_shift = config->pad_bits % 8;
        if (config->reg_stride)
                map->reg_stride = config->reg_stride;
        else