i2c: ali1535: Fix an error handling path in ali1535_probe()

If i2c_add_adapter() fails, the request_region() call in ali1535_setup()
must be undone by a corresponding release_region() call, as done in the
remove function.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/0daf63d7a2ce74c02e2664ba805bbfadab7d25e5.1741031571.git.christophe.jaillet@wanadoo.fr

diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
index 544c94e86b8967b082dcf3eee966ea0946a96593..1eac358380405838d15551e353605cab0a7e5e65 100644 (file)
--- a/drivers/i2c/busses/i2c-ali1535.c
+++ b/drivers/i2c/busses/i2c-ali1535.c
@@ -485,6 +485,8 @@ MODULE_DEVICE_TABLE(pci, ali1535_ids);
 
 static int ali1535_probe(struct pci_dev *dev, const struct pci_device_id *id)
 {
+       int ret;
+
        if (ali1535_setup(dev)) {
                dev_warn(&dev->dev,
                        "ALI1535 not detected, module not inserted.\n");
@@ -496,7 +498,15 @@ static int ali1535_probe(struct pci_dev *dev, const struct pci_device_id *id)
 
        snprintf(ali1535_adapter.name, sizeof(ali1535_adapter.name),
                "SMBus ALI1535 adapter at %04x", ali1535_offset);
-       return i2c_add_adapter(&ali1535_adapter);
+       ret = i2c_add_adapter(&ali1535_adapter);
+       if (ret)
+               goto release_region;
+
+       return 0;
+
+release_region:
+       release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
+       return ret;
 }
 
 static void ali1535_remove(struct pci_dev *dev)