]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
maple_tree: Use kfree_rcu in ma_free_rcu
authorPedro Falcato <pfalcato@suse.de>
Wed, 3 Sep 2025 12:59:58 +0000 (14:59 +0200)
committerVlastimil Babka <vbabka@suse.cz>
Mon, 29 Sep 2025 07:24:03 +0000 (09:24 +0200)
kfree_rcu is an optimized version of call_rcu + kfree. It used to not be
possible to call it on non-kmalloc objects, but this restriction was
lifted ever since SLOB was dropped from the kernel, and since commit
6c6c47b063b5 ("mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()").

Thus, replace call_rcu + mt_free_rcu with kfree_rcu.

Signed-off-by: Pedro Falcato <pfalcato@suse.de>
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
lib/maple_tree.c

index d034f170ac897341b40cfd050b6aee86b6d2cf60..c706e2e48f884fd156e25be2b17eb5e154774db7 100644 (file)
@@ -187,13 +187,6 @@ static inline void mt_free_bulk(size_t size, void __rcu **nodes)
        kmem_cache_free_bulk(maple_node_cache, size, (void **)nodes);
 }
 
-static void mt_free_rcu(struct rcu_head *head)
-{
-       struct maple_node *node = container_of(head, struct maple_node, rcu);
-
-       kmem_cache_free(maple_node_cache, node);
-}
-
 /*
  * ma_free_rcu() - Use rcu callback to free a maple node
  * @node: The node to free
@@ -204,7 +197,7 @@ static void mt_free_rcu(struct rcu_head *head)
 static void ma_free_rcu(struct maple_node *node)
 {
        WARN_ON(node->parent != ma_parent_ptr(node));
-       call_rcu(&node->rcu, mt_free_rcu);
+       kfree_rcu(node, rcu);
 }
 
 static void mt_set_height(struct maple_tree *mt, unsigned char height)
@@ -5099,7 +5092,7 @@ static void mt_free_walk(struct rcu_head *head)
        mt_free_bulk(node->slot_len, slots);
 
 free_leaf:
-       mt_free_rcu(&node->rcu);
+       mt_free_one(node);
 }
 
 static inline void __rcu **mte_destroy_descend(struct maple_enode **enode,
@@ -5183,7 +5176,7 @@ next:
 
 free_leaf:
        if (free)
-               mt_free_rcu(&node->rcu);
+               mt_free_one(node);
        else
                mt_clear_meta(mt, node, node->type);
 }