]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
daemon: Plug memory leaks
authorAlex Jia <ajia@redhat.com>
Thu, 12 Apr 2012 09:10:42 +0000 (17:10 +0800)
committerDaniel P. Berrange <berrange@redhat.com>
Mon, 16 Apr 2012 11:42:37 +0000 (12:42 +0100)
* daemon/libvirtd-config.c (daemonConfigFree): fix memory leaks.

How to reproduce?

% make && make -C tests check TESTS=libvirtdconftest
% cd tests && valgrind -v --leak-check=full ./libvirtdconftest

actual result:

==11008== 185 bytes in 5 blocks are definitely lost in loss record 3 of 5
==11008==    at 0x4A05FDE: malloc (vg_replace_malloc.c:236)
==11008==    by 0x39CF07F6E1: strdup (strdup.c:43)
==11008==    by 0x406626: daemonConfigLoadOptions (libvirtd-config.c:438)
==11008==    by 0x406800: daemonConfigLoadData (libvirtd-config.c:492)
==11008==    by 0x403CCF: testCorrupt (libvirtdconftest.c:110)
==11008==    by 0x404FAD: virtTestRun (testutils.c:145)
==11008==    by 0x403A34: mymain (libvirtdconftest.c:219)
==11008==    by 0x404687: virtTestMain (testutils.c:700)
==11008==    by 0x39CF01ECDC: (below main) (libc-start.c:226)
==11008==
==11008== LEAK SUMMARY:
==11008==    definitely lost: 185 bytes in 5 blocks

Signed-off-by: Alex Jia <ajia@redhat.com>
(cherry picked from commit d0eaf4b124ba5b2016107586c75aa4b1a985b157)

Conflicts:

daemon/libvirtd-config.c

daemon/libvirtd.c

index af07e840bc737b76682be38682c63e1309a77c1f..1ffbfbbd33f90dcc8afe2342d72ed7f4ead93e6a 100644 (file)
@@ -993,6 +993,7 @@ daemonConfigFree(struct daemonConfig *data)
     VIR_FREE(data->cert_file);
     VIR_FREE(data->crl_file);
 
+    VIR_FREE(data->host_uuid);
     VIR_FREE(data->log_filters);
     VIR_FREE(data->log_outputs);