api: fix coverity warning about uninitialized variable

Fix Uninitialized scalar variable, reported by Coverity tool:

CID 258269 (#1 of 1): Uninitialized scalar variable (UNINIT).
uninit_use: Using uninitialized value version.

In _cgroup_create_cgroup(), the (cg_version_t)version is uninitialized
and might be read the version in false path. It worked until now
because the version is assigned in the true path and given that its enum
the checks are not bounded by range, but rather specific.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

diff --git a/src/api.c b/src/api.c
index 07d16f578de851ee4f047abfecc9249de5004a2c..469e242657ebe7083ea66b21eee7be30f977e2e7 100644 (file)
--- a/src/api.c
+++ b/src/api.c
@@ -2611,7 +2611,7 @@ static int _cgroup_create_cgroup(const struct cgroup * const cgroup,
                                 const struct cgroup_controller * const controller,
                                 int ignore_ownership)
 {
-       enum cg_version_t version;
+       enum cg_version_t version = CGROUP_UNK;
        char *fts_path[2];
        char *base = NULL;
        char *path = NULL;