]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuMigrationSrcIsSafe: Drop 'DEBUG' message about qemu supporting cache dropping
authorPeter Krempa <pkrempa@redhat.com>
Mon, 8 Sep 2025 13:59:57 +0000 (15:59 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 23 Sep 2025 16:57:00 +0000 (18:57 +0200)
The feature exists for a long time, no need to add extra notice about
it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_migration.c

index a8f4dd489c407db5e7a452d1fa0c0ba22c30ba24..dd171f953cb6eac593ff8a73f787098f9483c6f4 100644 (file)
@@ -1805,14 +1805,10 @@ qemuMigrationSrcIsSafe(virDomainObj *vm,
          * which case cache mode doesn't matter) or used with cache=none or used with cache=directsync */
         if (disk->src->shared ||
             disk->cachemode == VIR_DOMAIN_DISK_CACHE_DISABLE ||
-            disk->cachemode == VIR_DOMAIN_DISK_CACHE_DIRECTSYNC)
+            disk->cachemode == VIR_DOMAIN_DISK_CACHE_DIRECTSYNC ||
+            virQEMUCapsGet(qemuCaps, QEMU_CAPS_MIGRATION_FILE_DROP_CACHE))
             continue;
 
-        if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_MIGRATION_FILE_DROP_CACHE)) {
-            VIR_DEBUG("QEMU supports flushing caches; migration is safe");
-            continue;
-        }
-
         virReportError(VIR_ERR_MIGRATE_UNSAFE, "%s",
                        _("Migration may lead to data corruption if disks use cache other than none or directsync"));
         return false;