]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
fbdev/pxafb: Unexport symbol
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 12 Jun 2025 08:16:34 +0000 (10:16 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 16 Jun 2025 07:08:05 +0000 (09:08 +0200)
Fix the compile-time warning

  drivers/video/fbdev/pxafb.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing

The affected symbol is not used anywhere, so remove the function
entirely.

v2:
- remove unused functions (Helge)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Helge Deller <deller@gmx.de>
Fixes: a934a57a42f6 ("scripts/misc-check: check missing #include <linux/export.h> when W=1")
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20250612081738.197826-12-tzimmermann@suse.de
drivers/video/fbdev/pxafb.c
include/linux/platform_data/video-pxafb.h

index ee6da5084242b5f93c386e1887b4f2c46085a4a3..baf87f34cc24bbdb2177356d02edcd7cdbddb2e3 100644 (file)
@@ -1030,9 +1030,8 @@ static inline unsigned int get_pcd(struct pxafb_info *fbi,
 
 /*
  * Some touchscreens need hsync information from the video driver to
- * function correctly. We export it here.  Note that 'hsync_time' and
- * the value returned from pxafb_get_hsync_time() is the *reciprocal*
- * of the hsync period in seconds.
+ * function correctly. We export it here.  Note that 'hsync_time' is
+ * the *reciprocal* of the hsync period in seconds.
  */
 static inline void set_hsync_time(struct pxafb_info *fbi, unsigned int pcd)
 {
@@ -1048,18 +1047,6 @@ static inline void set_hsync_time(struct pxafb_info *fbi, unsigned int pcd)
        fbi->hsync_time = htime;
 }
 
-unsigned long pxafb_get_hsync_time(struct device *dev)
-{
-       struct pxafb_info *fbi = dev_get_drvdata(dev);
-
-       /* If display is blanked/suspended, hsync isn't active */
-       if (!fbi || (fbi->state != C_ENABLE))
-               return 0;
-
-       return fbi->hsync_time;
-}
-EXPORT_SYMBOL(pxafb_get_hsync_time);
-
 static int setup_frame_dma(struct pxafb_info *fbi, int dma, int pal,
                           unsigned long start, size_t size)
 {
index 6333bac166a5a5e9139bc7cde580a9fcb40663bb..38c24c77ba43bb61f0aae6bfe17238b25ebc78ae 100644 (file)
@@ -150,7 +150,6 @@ struct pxafb_mach_info {
 };
 
 void pxa_set_fb_info(struct device *, struct pxafb_mach_info *);
-unsigned long pxafb_get_hsync_time(struct device *dev);
 
 /* smartpanel related */
 #define SMART_CMD_A0                    (0x1 << 8)