]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
clusapi: add inline comment describing why we use so many "if 0" in this IDL.
authorGünther Deschner <gd@samba.org>
Fri, 22 May 2015 08:59:03 +0000 (10:59 +0200)
committerJeremy Allison <jra@samba.org>
Tue, 2 Jun 2015 00:28:24 +0000 (02:28 +0200)
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
librpc/idl/clusapi.idl

index 7747115eee455cdff0781902c4d1b2459a78910f..3e87114150dd2fd121a7a149dae89bde5e44f5b0 100644 (file)
@@ -13,6 +13,11 @@ import "security.idl";
        interface clusapi
 {
 #if 0
+       /*
+        * pidl does not yet have a real [context_handle] implementation, so we
+        * just use some defines here.
+        */
+
        typedef [context_handle] void *HCLUSTER_RPC;
        typedef [context_handle] void *HNODE_RPC;
        typedef [context_handle] void *HGROUP_RPC;
@@ -73,6 +78,13 @@ import "security.idl";
        /* Function 0x00 */
 
 #if 0
+       /*
+        * pidl cannot generate code for functions that return structures in
+        * IDL, therefore pretend the function is void and add the returned
+        * structure as an out parameter. This is what we do with pretty much
+        * all the Open calls right now in this interface - gd
+        */
+
        HCLUSTER_RPC
        clusapi_OpenCluster(
                [ out ] WERROR *Status