]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
gdb: remove some unnecessary frame_info_ptr resets
authorSimon Marchi <simon.marchi@efficios.com>
Wed, 31 Jan 2024 15:54:09 +0000 (10:54 -0500)
committerSimon Marchi <simon.marchi@efficios.com>
Wed, 31 Jan 2024 21:19:29 +0000 (16:19 -0500)
This code was probably needed before we had reinflatable
frame_info_ptrs, it's not necessary anymore.

Change-Id: I5474c6081ee1e39624c9266b05dbe01351a130b5
Approved-By: Tom Tromey <tom@tromey.com>
gdb/arm-linux-tdep.c
gdb/elfread.c
gdb/infcall.c
gdb/infcmd.c
gdb/infrun.c
gdb/stack.c

index 97debab81d6ff13ca1adb2112149b20e3416a231..b559de0fb2d6b38ede6438512e5d06413a2b1582 100644 (file)
@@ -1047,9 +1047,6 @@ arm_linux_copy_svc (struct gdbarch *gdbarch, struct regcache *regs,
            = set_momentary_breakpoint (gdbarch, sal, get_frame_id (frame),
                                        bp_step_resume).release ();
 
-         /* set_momentary_breakpoint invalidates FRAME.  */
-         frame = NULL;
-
          /* We need to make sure we actually insert the momentary
             breakpoint set above.  */
          insert_breakpoints ();
index eca27008678e450b5163af8c32d4097f4ff5efd3..e8a0c4d7a2cfce34db1d7daa39615ccaf95f2949 100644 (file)
@@ -989,8 +989,6 @@ elf_gnu_ifunc_resolver_stop (code_breakpoint *b)
                                    prev_frame_id,
                                    bp_gnu_ifunc_resolver_return).release ();
 
-      /* set_momentary_breakpoint invalidates PREV_FRAME.  */
-      prev_frame = NULL;
 
       /* Add new b_return to the ring list b->related_breakpoint.  */
       gdb_assert (b_return->related_breakpoint == b_return);
index 4079f9e7cab0bb84fea9ac5b5ba3cbf9253ebfd1..145ce25b0d1beb22b5354b8de5e09988e5bc07de 100644 (file)
@@ -1300,9 +1300,6 @@ call_function_by_hand_dummy (struct value *function,
       = set_momentary_breakpoint (gdbarch, sal,
                                  dummy_id, bp_call_dummy).release ();
 
-    /* set_momentary_breakpoint invalidates FRAME.  */
-    frame = NULL;
-
     bpt->disposition = disp_del;
     gdb_assert (bpt->related_breakpoint == bpt);
 
index 5e5f75021f209146fdcaf2fd13a04f8c8abe18a1..54063b37beb8b7427600ffac45c98181e3c13df4 100644 (file)
@@ -1757,9 +1757,6 @@ finish_forward (struct finish_command_fsm *sm, frame_info_ptr frame)
                                             get_stack_frame_id (frame),
                                             bp_finish);
 
-  /* set_momentary_breakpoint invalidates FRAME.  */
-  frame = nullptr;
-
   set_longjmp_breakpoint (tp, frame_id);
 
   /* We want to print return value, please...  */
index 8ccaf3326dc6a5606f2212ebab5f2e1eec0d8fb1..87965fb12742a0f03ca9e9a47635cf6acb60bdd5 100644 (file)
@@ -8848,9 +8848,6 @@ insert_exception_resume_breakpoint (struct thread_info *tp,
                                               handler,
                                               bp_exception_resume).release ();
 
-         /* set_momentary_breakpoint_at_pc invalidates FRAME.  */
-         frame = nullptr;
-
          tp->control.exception_resume_breakpoint = bp;
        }
     }
index bf3158393efa8172c49acddc2efe2a9adec4ae7d..e4442428285548b71c98fbe757efcf880b14db1a 100644 (file)
@@ -2307,9 +2307,6 @@ print_variable_and_value_data::operator() (const char *print_name,
 
   print_variable_and_value (print_name, sym, frame, stream, num_tabs);
 
-  /* print_variable_and_value invalidates FRAME.  */
-  frame = NULL;
-
   values_printed = 1;
 }