Suppress more variable-set-but-not-used warnings from clang 15.

Mop up assorted set-but-not-used warnings in the back branches.
This includes back-patching relevant fixes from commit 152c9f7b8
the rest of the way, but there are also several cases that did not
appear in HEAD.  Some of those we'd fixed in a retail way but not
back-patched, and others I think just got rewritten out of existence
during nearby refactoring.

While here, also back-patch b1980f6d0 (PL/Tcl: Fix compiler warnings
with Tcl 8.6) into 9.2, so that that branch compiles warning-free
with modern Tcl.

Per project policy, this is a candidate for back-patching into
out-of-support branches: it suppresses annoying compiler warnings
but changes no behavior.  Hence, back-patch all the way to 9.2.

Discussion: https://postgr.es/m/514615.1663615243@sss.pgh.pa.us

diff --git a/src/backend/optimizer/util/var.c b/src/backend/optimizer/util/var.c
index da16bf9fa462a4b5515ff1fbf86055c1833288d6..dd952008637e37442fe829a91508a37ffb571a52 100644 (file)
--- a/src/backend/optimizer/util/var.c
+++ b/src/backend/optimizer/util/var.c
@@ -699,16 +699,13 @@ flatten_join_alias_vars_mutator(Node *node,
                        RowExpr    *rowexpr;
                        List       *fields = NIL;
                        List       *colnames = NIL;
-                       AttrNumber      attnum;
                        ListCell   *lv;
                        ListCell   *ln;
 
-                       attnum = 0;
                        Assert(list_length(rte->joinaliasvars) == list_length(rte->eref->colnames));
                        forboth(lv, rte->joinaliasvars, ln, rte->eref->colnames)
                        {
                                newvar = (Node *) lfirst(lv);
-                               attnum++;
                                /* Ignore dropped columns */
                                if (newvar == NULL)
                                        continue;

diff --git a/src/backend/utils/adt/varlena.c b/src/backend/utils/adt/varlena.c
index cbd6b8fa385fc2ee0e1397c77c0a2ec1c6dfeec0..81c6ee22d4b477144ba917f80c7b97b5f503250a 100644 (file)
--- a/src/backend/utils/adt/varlena.c
+++ b/src/backend/utils/adt/varlena.c
@@ -4326,7 +4326,6 @@ text_to_array_internal(PG_FUNCTION_ARGS)
                 * to search for occurrences of fldsep.
                 */
                TextPositionState state;
-               int                     fldnum;
                int                     start_posn;
                int                     end_posn;
                int                     chunk_len;
@@ -4377,7 +4376,7 @@ text_to_array_internal(PG_FUNCTION_ARGS)
                /* start_ptr points to the start_posn'th character of inputstring */
                start_ptr = VARDATA_ANY(inputstring);
 
-               for (fldnum = 1;; fldnum++) /* field number is 1 based */
+               for (;;)
                {
                        CHECK_FOR_INTERRUPTS();