]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clk: keystone: syscon-clk: fix regmap leak on probe failure
authorJohan Hovold <johan@kernel.org>
Thu, 27 Nov 2025 13:42:43 +0000 (14:42 +0100)
committerStephen Boyd <sboyd@kernel.org>
Sun, 30 Nov 2025 20:05:45 +0000 (12:05 -0800)
The mmio regmap allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is
released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes: a250cd4c1901 ("clk: keystone: syscon-clk: Do not use syscon helper to build regmap")
Cc: stable@vger.kernel.org # 6.15
Cc: Andrew Davis <afd@ti.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/keystone/syscon-clk.c

index c509929da854529c40aff71caa87f767aecaad22..ecf180a7949c9345b7a06e1e193705cfa925c430 100644 (file)
@@ -129,7 +129,7 @@ static int ti_syscon_gate_clk_probe(struct platform_device *pdev)
        if (IS_ERR(base))
                return PTR_ERR(base);
 
-       regmap = regmap_init_mmio(dev, base, &ti_syscon_regmap_cfg);
+       regmap = devm_regmap_init_mmio(dev, base, &ti_syscon_regmap_cfg);
        if (IS_ERR(regmap))
                return dev_err_probe(dev, PTR_ERR(regmap),
                                     "failed to get regmap\n");