]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Add missing return statements after self_destruct() in UFS
authorAmos Jeffries <squid3@treenet.co.nz>
Thu, 23 Feb 2017 10:46:27 +0000 (23:46 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Thu, 23 Feb 2017 10:46:27 +0000 (23:46 +1300)
 Detected by Coverity Scan. Issues 11542221154223.

src/fs/ufs/UFSSwapDir.cc

index 0c6afa57b6a317feaac038bb03bb5de35fb5ae3a..48170703cb1d4d2c740353aca06be5eac57e394b 100644 (file)
@@ -228,13 +228,17 @@ Fs::Ufs::UFSSwapDir::optionIOParse(char const *option, const char *value, int is
         /* silently ignore this */
         return true;
 
-    if (!value)
+    if (!value) {
         self_destruct();
+        return false;
+    }
 
     DiskIOModule *module = DiskIOModule::Find(value);
 
-    if (!module)
+    if (!module) {
         self_destruct();
+        return false;
+    }
 
     changeIO(module);