🔧 Add Python formatting hooks to pre-commit (#4890)

diff --git a/.github/actions/comment-docs-preview-in-pr/app/main.py b/.github/actions/comment-docs-preview-in-pr/app/main.py
index 3b10e0ee089e10304cedc79429b5fff7108dfb44..c9fb7cbbefac61a475467302784eb8fd4df086ec 100644 (file)
--- a/.github/actions/comment-docs-preview-in-pr/app/main.py
+++ b/.github/actions/comment-docs-preview-in-pr/app/main.py
@@ -48,9 +48,7 @@ if __name__ == "__main__":
             use_pr = pr
             break
     if not use_pr:
-        logging.error(
-            f"No PR found for hash: {event.workflow_run.head_commit.id}"
-        )
+        logging.error(f"No PR found for hash: {event.workflow_run.head_commit.id}")
         sys.exit(0)
     github_headers = {
         "Authorization": f"token {settings.input_token.get_secret_value()}"

diff --git a/.github/actions/notify-translations/app/main.py b/.github/actions/notify-translations/app/main.py
index 7d6c1a4d20a7fb494574b04e255e7e828e88ded9..823685e00b12219dde7bafdb01a5bc70e595c2be 100644 (file)
--- a/.github/actions/notify-translations/app/main.py
+++ b/.github/actions/notify-translations/app/main.py
@@ -1,7 +1,7 @@
 import logging
+import random
 import time
 from pathlib import Path
-import random
 from typing import Dict, Optional
 
 import yaml
@@ -54,7 +54,7 @@ if __name__ == "__main__":
     )
     if pr.state == "open":
         logging.debug(f"PR is open: {pr.number}")
-        label_strs = set([label.name for label in pr.get_labels()])
+        label_strs = {label.name for label in pr.get_labels()}
         if lang_all_label in label_strs and awaiting_label in label_strs:
             logging.info(
                 f"This PR seems to be a language translation and awaiting reviews: {pr.number}"

diff --git a/.github/actions/people/app/main.py b/.github/actions/people/app/main.py
index 0b6ff4063c898bbb92890fb1c70a8f8e590a8529..9de6fc25058566746e30617c27b21a124a2eb779 100644 (file)
--- a/.github/actions/people/app/main.py
+++ b/.github/actions/people/app/main.py
@@ -14,7 +14,7 @@ from pydantic import BaseModel, BaseSettings, SecretStr
 github_graphql_url = "https://api.github.com/graphql"
 
 issues_query = """
-query Q($after: String) { 
+query Q($after: String) {
   repository(name: "fastapi", owner: "tiangolo") {
     issues(first: 100, after: $after) {
       edges {
@@ -47,7 +47,7 @@ query Q($after: String) {
 """
 
 prs_query = """
-query Q($after: String) { 
+query Q($after: String) {
   repository(name: "fastapi", owner: "tiangolo") {
     pullRequests(first: 100, after: $after) {
       edges {

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 2d9dce2d877e25509211fa42042111e98c491461..f6a0b251c20964fe23eda4e9b0b0e76af97d1f2d 100644 (file)
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -11,4 +11,38 @@ repos:
         -   --unsafe
     -   id: end-of-file-fixer
     -   id: trailing-whitespace
-
+-   repo: https://github.com/asottile/pyupgrade
+    rev: v2.32.1
+    hooks:
+    -   id: pyupgrade
+        args:
+        - --py3-plus
+        - --keep-runtime-typing
+-   repo: https://github.com/myint/autoflake
+    rev: v1.4
+    hooks:
+    -   id: autoflake
+        args:
+        - --recursive
+        - --in-place
+        - --remove-all-unused-imports
+        - --remove-unused-variables
+        - --expand-star-imports
+        - --exclude
+        - __init__.py
+        - --remove-duplicate-keys
+-   repo: https://github.com/pycqa/isort
+    rev: 5.10.1
+    hooks:
+    -   id: isort
+        name: isort (python)
+    -   id: isort
+        name: isort (cython)
+        types: [cython]
+    -   id: isort
+        name: isort (pyi)
+        types: [pyi]
+-   repo: https://github.com/psf/black
+    rev: 22.3.0
+    hooks:
+    -   id: black

diff --git a/fastapi/routing.py b/fastapi/routing.py
index db39d3ffd1b158d8e90808cbbd73cdccce0df6f8..a6542c15a035e816a8122e163696ff9a4c77d324 100644 (file)
--- a/fastapi/routing.py
+++ b/fastapi/routing.py
@@ -364,7 +364,7 @@ class APIRoute(routing.Route):
         self.path_regex, self.path_format, self.param_convertors = compile_path(path)
         if methods is None:
             methods = ["GET"]
-        self.methods: Set[str] = set([method.upper() for method in methods])
+        self.methods: Set[str] = {method.upper() for method in methods}
         if isinstance(generate_unique_id_function, DefaultPlaceholder):
             current_generate_unique_id: Callable[
                 ["APIRoute"], str