]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
kbuild: Install dtb files as 0644 in Makefile.dtbinst
authorDragan Simic <dsimic@manjaro.org>
Mon, 10 Jun 2024 05:21:12 +0000 (07:21 +0200)
committerMasahiro Yamada <masahiroy@kernel.org>
Tue, 25 Jun 2024 15:18:57 +0000 (00:18 +0900)
The compiled dtb files aren't executable, so install them with 0644 as their
permission mode, instead of defaulting to 0755 for the permission mode and
installing them with the executable bits set.

Some Linux distributions, including Debian, [1][2][3] already include fixes
in their kernel package build recipes to change the dtb file permissions to
0644 in their kernel packages.  These changes, when additionally propagated
into the long-term kernel versions, will allow such distributions to remove
their downstream fixes.

[1] https://salsa.debian.org/kernel-team/linux/-/merge_requests/642
[2] https://salsa.debian.org/kernel-team/linux/-/merge_requests/749
[3] https://salsa.debian.org/kernel-team/linux/-/blob/debian/6.8.12-1/debian/rules.real#L193

Cc: Diederik de Haas <didi.debian@cknow.org>
Cc: <stable@vger.kernel.org>
Fixes: aefd80307a05 ("kbuild: refactor Makefile.dtbinst more")
Signed-off-by: Dragan Simic <dsimic@manjaro.org>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/Makefile.dtbinst

index 67956f6496a5c062c65375dcd8c712d0be91d771..9d920419a62cf4fd05a4fba6a003cbe53d496ee3 100644 (file)
@@ -17,7 +17,7 @@ include $(srctree)/scripts/Kbuild.include
 dst := $(INSTALL_DTBS_PATH)
 
 quiet_cmd_dtb_install = INSTALL $@
-      cmd_dtb_install = install -D $< $@
+      cmd_dtb_install = install -D -m 0644 $< $@
 
 $(dst)/%: $(obj)/%
        $(call cmd,dtb_install)