]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commitdiff
runqemu-ifup: remove uid parameter
authorAdrian Freihofer <adrian.freihofer@gmail.com>
Thu, 22 Jun 2023 17:01:21 +0000 (19:01 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 24 Jun 2023 11:19:52 +0000 (12:19 +0100)
ip tuntap does not need the uid, it was an unused variable/parameter.
Backward compatibility should be fine.

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/runqemu-ifup

index 5dc765dee826b73f47eea9772d64a11af9f54d18..267145180203e739df7429d1c8d8b8ffdc160644 100755 (executable)
@@ -21,7 +21,7 @@
 #
 
 usage() {
-       echo "sudo $(basename $0) <uid> <gid>"
+       echo "sudo $(basename $0) <gid>"
 }
 
 if [ $EUID -ne 0 ]; then
@@ -29,17 +29,20 @@ if [ $EUID -ne 0 ]; then
        exit 1
 fi
 
-if [ $# -ne 2 ]; then
+if [ $# -eq 2 ]; then
+       echo "Warning: uid parameter is ignored. It is no longer needed."
+       GROUP="$2"
+elif [ $# -eq 1 ]; then
+       GROUP="$1"
+else
        usage
        exit 1
 fi
 
-USERID="-u $1"
-GROUP="-g $2"
 
 if taps=$(ip tuntap list 2>/dev/null); then
        tap_no=$(( $(echo "$taps" |cut -f 1 -d ":" | sed 's/tap//g' | sort -rn | head -n 1) + 1 ))
-       ip tuntap add tap$tap_no mode tap group $2 && TAP=tap$tap_no
+       ip tuntap add tap$tap_no mode tap group "$GROUP" && TAP=tap$tap_no
 fi
 
 if [ -z $TAP ]; then