]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: stmmac: sti: use PHY_INTF_SEL_x to select PHY interface
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thu, 6 Nov 2025 11:23:37 +0000 (11:23 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 8 Nov 2025 03:05:49 +0000 (19:05 -0800)
Use the common dwmac definitions for the PHY interface selection field,
adding MII_PHY_SEL_VAL() temporarily to avoid line wrapping.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1vGy5Z-0000000DhQV-1e2l@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c

index 53d5ce1f6dc699574971e69cbf6532e7defa6652..1e8769a81d77f38ad6c9a4c230d488582d7de6af 100644 (file)
  *     001-RGMII
  *     010-SGMII
  *     100-RMII
+ * These are the DW MAC phy_intf_sel values
  */
 #define MII_PHY_SEL_MASK       GENMASK(4, 2)
-#define ETH_PHY_SEL_RMII       BIT(4)
-#define ETH_PHY_SEL_SGMII      BIT(3)
-#define ETH_PHY_SEL_RGMII      BIT(2)
-#define ETH_PHY_SEL_GMII       0x0
-#define ETH_PHY_SEL_MII                0x0
+#define MII_PHY_SEL_VAL(val)   FIELD_PREP_CONST(MII_PHY_SEL_MASK, val)
+#define ETH_PHY_SEL_RMII       MII_PHY_SEL_VAL(PHY_INTF_SEL_RMII)
+#define ETH_PHY_SEL_SGMII      MII_PHY_SEL_VAL(PHY_INTF_SEL_SGMII)
+#define ETH_PHY_SEL_RGMII      MII_PHY_SEL_VAL(PHY_INTF_SEL_RGMII)
+#define ETH_PHY_SEL_GMII       MII_PHY_SEL_VAL(PHY_INTF_SEL_GMII_MII)
+#define ETH_PHY_SEL_MII                MII_PHY_SEL_VAL(PHY_INTF_SEL_GMII_MII)
 
 struct sti_dwmac {
        phy_interface_t interface;      /* MII interface */