]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: musb: Modify the "HWVers" register address
authorXingxing Luo <xingxing.luo@unisoc.com>
Fri, 22 Sep 2023 07:59:29 +0000 (15:59 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Oct 2023 09:13:30 +0000 (11:13 +0200)
commit 6658a62e1ddf726483cb2d8bf45ea3f9bd533074 upstream.

musb HWVers rgister address is not 0x69, if we operate the
wrong address 0x69, it will cause a kernel crash, because
there is no register corresponding to this address in the
additional control register of musb. In fact, HWVers has
been defined in musb_register.h, and the name is
"MUSB_HWVERS", so We need to use this macro instead of 0x69.

Fixes: c2365ce5d5a0 ("usb: musb: replace hard coded registers with defines")
Cc: stable@vger.kernel.org
Signed-off-by: Xingxing Luo <xingxing.luo@unisoc.com>
Link: https://lore.kernel.org/r/20230922075929.31074-1-xingxing.luo@unisoc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/musb/musb_debugfs.c

index 480b2119f1e7d7debfa128d1ee1d8fe7aaf9a3eb..20bc4d1f85b1034c23d44d6f51d8dd3ffeb8baf8 100644 (file)
@@ -64,7 +64,7 @@ static const struct musb_register_map musb_regmap[] = {
        { "IntrUsbE",   MUSB_INTRUSBE,  8 },
        { "DevCtl",     MUSB_DEVCTL,    8 },
        { "VControl",   0x68,           32 },
-       { "HWVers",     0x69,           16 },
+       { "HWVers",     MUSB_HWVERS,    16 },
        { "LinkInfo",   MUSB_LINKINFO,  8 },
        { "VPLen",      MUSB_VPLEN,     8 },
        { "HS_EOF1",    MUSB_HS_EOF1,   8 },