Squid crashes when ICAPS and a sslcrtvalidator used together (#328)

Squid hits an assertions when tries to remove an comm_close handler from
the already closed connection object.

This is a Measurement Factory project

diff --git a/src/adaptation/icap/Xaction.cc b/src/adaptation/icap/Xaction.cc
index c262386e465c7713196e6ee41fdef31ebafd2022..62b5cd4428953f25d68f906dd420b10b5802f221 100644 (file)
--- a/src/adaptation/icap/Xaction.cc
+++ b/src/adaptation/icap/Xaction.cc
@@ -741,7 +741,7 @@ Adaptation::Icap::Xaction::handleSecuredPeer(Security::EncryptorAnswer &answer)
     securer = NULL;
 
     if (closer != NULL) {
-        if (answer.conn != NULL)
+        if (Comm::IsConnOpen(answer.conn))
             comm_remove_close_handler(answer.conn->fd, closer);
         else
             closer->cancel("securing completed");