midx-write: fix leaking buffer

The buffer used to compute the final MIDX name is never released. Plug
this memory leak.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/midx-write.c b/midx-write.c
index 1ef62c4f4bebf6b837b015d97f28e3dda359725c..625c7d31371201150c8a6a87a60f9f9ec1e9856b 100644 (file)
--- a/midx-write.c
+++ b/midx-write.c
@@ -1445,6 +1445,8 @@ static int write_midx_internal(const char *object_dir,
                        return -1;
                }
 
+               strbuf_release(&final_midx_name);
+
                keep_hashes[ctx.num_multi_pack_indexes_before] =
                        xstrdup(hash_to_hex(midx_hash));
 

diff --git a/t/t5334-incremental-multi-pack-index.sh b/t/t5334-incremental-multi-pack-index.sh
index c3b08acc733d9419e302b1cc46261ddda7e93ee0..471994c4bc89d8faa5bb39e8614439573f388ba3 100755 (executable)
--- a/t/t5334-incremental-multi-pack-index.sh
+++ b/t/t5334-incremental-multi-pack-index.sh
@@ -1,6 +1,8 @@
 #!/bin/sh
 
 test_description='incremental multi-pack-index'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-midx.sh