]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: qcom: cmd-db: Cast sizeof() to int to silence field width warning
authorStephen Boyd <swboyd@chromium.org>
Wed, 15 Apr 2020 06:20:33 +0000 (23:20 -0700)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Mon, 20 Apr 2020 06:06:17 +0000 (23:06 -0700)
We pass the result of sizeof() here to tell the printk format specifier
how many bytes to print. That expects an int though and sizeof() isn't
that type. Cast to int to silence this warning:

drivers/soc/qcom/cmd-db.c: In function 'cmd_db_debugfs_dump':
drivers/soc/qcom/cmd-db.c:281:30: warning: field width specifier '*' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Fixes: d6815c5c43d4 ("soc: qcom: cmd-db: Add debugfs dumping file")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20200415062033.66406-1-swboyd@chromium.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/soc/qcom/cmd-db.c

index 8b2b7357b6da9c4fb495f3f45a178e1c3aff7f77..57382b64f1daeb66c972857cf08a221b57c2a67e 100644 (file)
@@ -279,7 +279,7 @@ static int cmd_db_debugfs_dump(struct seq_file *seq, void *p)
                ent = rsc_to_entry_header(rsc);
                for (j = 0; j < le16_to_cpu(rsc->cnt); j++, ent++) {
                        seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr),
-                                  sizeof(ent->id), ent->id);
+                                  (int)sizeof(ent->id), ent->id);
 
                        len = le16_to_cpu(ent->len);
                        if (len) {