]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
genirq/proc: Add missing space separator back
authorThomas Gleixner <tglx@linutronix.de>
Tue, 3 Dec 2024 10:40:43 +0000 (11:40 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 3 Dec 2024 13:59:34 +0000 (14:59 +0100)
The recent conversion of show_interrupts() to seq_put_decimal_ull_width()
caused a formatting regression as it drops a previosuly existing space
separator.

Add it back by unconditionally inserting a space after the interrupt
counts and removing the extra leading space from the chip name prints.

Fixes: f9ed1f7c2e26 ("genirq/proc: Use seq_put_decimal_ull_width() for decimal values")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: David Wang <00107082@163.com>
Link: https://lore.kernel.org/all/87zfldt5g4.ffs@tglx
Closes: https://lore.kernel.org/all/4ce18851-6e9f-bbe-8319-cc5e69fb45c@linux-m68k.org
kernel/irq/proc.c

index f36c33bd2da46c6657639d680849b44031fcb502..8e29809de38de5cb2fc66f51b821234c4c90dd90 100644 (file)
@@ -501,17 +501,18 @@ int show_interrupts(struct seq_file *p, void *v)
 
                seq_put_decimal_ull_width(p, " ", cnt, 10);
        }
+       seq_putc(p, ' ');
 
        raw_spin_lock_irqsave(&desc->lock, flags);
        if (desc->irq_data.chip) {
                if (desc->irq_data.chip->irq_print_chip)
                        desc->irq_data.chip->irq_print_chip(&desc->irq_data, p);
                else if (desc->irq_data.chip->name)
-                       seq_printf(p, " %8s", desc->irq_data.chip->name);
+                       seq_printf(p, "%8s", desc->irq_data.chip->name);
                else
-                       seq_printf(p, " %8s", "-");
+                       seq_printf(p, "%8s", "-");
        } else {
-               seq_printf(p, " %8s", "None");
+               seq_printf(p, "%8s", "None");
        }
        if (desc->irq_data.domain)
                seq_printf(p, " %*lu", prec, desc->irq_data.hwirq);