]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i3c: master add i3c_master_attach_boardinfo to preserve boardinfo
authorParshuram Thombare <pthombar@cadence.com>
Thu, 21 May 2020 09:32:22 +0000 (11:32 +0200)
committerBoris Brezillon <boris.brezillon@collabora.com>
Wed, 19 Aug 2020 07:29:56 +0000 (09:29 +0200)
Boardinfo was lost if I3C object for devices with boardinfo
available are not created or not added to the I3C device list
because of some failure e.g. SETDASA failed, retrieve info failed etc
This patch adds i3c_master_attach_boardinfo which scan boardinfo list
in the master object and 'attach' it to the I3C device object.

Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
Signed-off-by: Parshuram Thombare <pthombar@cadence.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://lore.kernel.org/linux-i3c/1590053542-389-1-git-send-email-pthombar@cadence.com
drivers/i3c/master.c

index 97f2e29265da789220cc727fd2990a0252d08b89..cc7564446ccd25e9bca41e35f23033f3d0cc65b9 100644 (file)
@@ -1782,6 +1782,21 @@ static void i3c_master_bus_cleanup(struct i3c_master_controller *master)
        i3c_master_detach_free_devs(master);
 }
 
+static void i3c_master_attach_boardinfo(struct i3c_dev_desc *i3cdev)
+{
+       struct i3c_master_controller *master = i3cdev->common.master;
+       struct i3c_dev_boardinfo *i3cboardinfo;
+
+       list_for_each_entry(i3cboardinfo, &master->boardinfo.i3c, node) {
+               if (i3cdev->info.pid != i3cboardinfo->pid)
+                       continue;
+
+               i3cdev->boardinfo = i3cboardinfo;
+               i3cdev->info.static_addr = i3cboardinfo->static_addr;
+               return;
+       }
+}
+
 static struct i3c_dev_desc *
 i3c_master_search_i3c_dev_duplicate(struct i3c_dev_desc *refdev)
 {
@@ -1837,10 +1852,10 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master,
        if (ret)
                goto err_detach_dev;
 
+       i3c_master_attach_boardinfo(newdev);
+
        olddev = i3c_master_search_i3c_dev_duplicate(newdev);
        if (olddev) {
-               newdev->boardinfo = olddev->boardinfo;
-               newdev->info.static_addr = olddev->info.static_addr;
                newdev->dev = olddev->dev;
                if (newdev->dev)
                        newdev->dev->desc = newdev;