]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: microchip: sparx5_pcb134: add missing I2C mux unit addresses
authorKrzysztof Kozlowski <krzk@kernel.org>
Fri, 5 Apr 2024 19:04:12 +0000 (21:04 +0200)
committerConor Dooley <conor.dooley@microchip.com>
Mon, 8 Apr 2024 15:55:46 +0000 (16:55 +0100)
The children of I2C mux should be named "i2c", according to DT schema
and bindings, and they should have unit address.

This fixes dtbs_check warnings like:

  sparx5_pcb134_emmc.dtb: i2c0-imux@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'i2c_sfp1', ...

and dtc W=1 warnings:

  sparx5_pcb134_board.dtsi:548.23-555.4: Warning (simple_bus_reg): /axi@600000000/sfp-eth12: missing or empty reg/ranges property

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi

index f3e226de5e5e913025146efcdef60a4c5c2093ef..e816e6e9d62dfa8322b24a99a46f6e56acbdbc17 100644 (file)
        pinctrl-10 = <&i2cmux_10>;
        pinctrl-11 = <&i2cmux_11>;
        pinctrl-12 = <&i2cmux_pins_i>;
-       i2c_sfp1: i2c_sfp1 {
+       i2c_sfp1: i2c@0 {
                reg = <0x0>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp2: i2c_sfp2 {
+       i2c_sfp2: i2c@1 {
                reg = <0x1>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp3: i2c_sfp3 {
+       i2c_sfp3: i2c@2 {
                reg = <0x2>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp4: i2c_sfp4 {
+       i2c_sfp4: i2c@3 {
                reg = <0x3>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp5: i2c_sfp5 {
+       i2c_sfp5: i2c@4 {
                reg = <0x4>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp6: i2c_sfp6 {
+       i2c_sfp6: i2c@5 {
                reg = <0x5>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp7: i2c_sfp7 {
+       i2c_sfp7: i2c@6 {
                reg = <0x6>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp8: i2c_sfp8 {
+       i2c_sfp8: i2c@7 {
                reg = <0x7>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp9: i2c_sfp9 {
+       i2c_sfp9: i2c@8 {
                reg = <0x8>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp10: i2c_sfp10 {
+       i2c_sfp10: i2c@9 {
                reg = <0x9>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp11: i2c_sfp11 {
+       i2c_sfp11: i2c@a {
                reg = <0xa>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp12: i2c_sfp12 {
+       i2c_sfp12: i2c@b {
                reg = <0xb>;
                #address-cells = <1>;
                #size-cells = <0>;
                     &gpio 61 GPIO_ACTIVE_HIGH
                     &gpio 54 GPIO_ACTIVE_HIGH>;
        idle-state = <0x8>;
-       i2c_sfp13: i2c_sfp13 {
+       i2c_sfp13: i2c@0 {
                reg = <0x0>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp14: i2c_sfp14 {
+       i2c_sfp14: i2c@1 {
                reg = <0x1>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp15: i2c_sfp15 {
+       i2c_sfp15: i2c@2 {
                reg = <0x2>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp16: i2c_sfp16 {
+       i2c_sfp16: i2c@3 {
                reg = <0x3>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp17: i2c_sfp17 {
+       i2c_sfp17: i2c@4 {
                reg = <0x4>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp18: i2c_sfp18 {
+       i2c_sfp18: i2c@5 {
                reg = <0x5>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp19: i2c_sfp19 {
+       i2c_sfp19: i2c@6 {
                reg = <0x6>;
                #address-cells = <1>;
                #size-cells = <0>;
        };
-       i2c_sfp20: i2c_sfp20 {
+       i2c_sfp20: i2c@7 {
                reg = <0x7>;
                #address-cells = <1>;
                #size-cells = <0>;