]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: core: reset gpio_device in loop in pinctrl_pins_show()
authorLéo DUBOIN <lduboin@freebox.fr>
Thu, 25 Apr 2024 13:58:02 +0000 (15:58 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 17 Jun 2024 07:22:24 +0000 (09:22 +0200)
We were not resetting the pointer to the associated gpio_device once
we are done displaying a pin's information.

This meant that once we reached the end of a gpio-range, if there
were pins right after it that did not belong to any known range,
they would be associated with the previous range's gpio device.

This resulted in those pins appearing as <4294966783:old_gdev> instead
of the expected <0:?> (due to gpio_num being -1).

Signed-off-by: Léo DUBOIN <lduboin@freebox.fr>
Link: https://lore.kernel.org/r/c40d0634abefa19e689ffd450e0f48a8d63c4fc4.1714049455.git.lduboin@freebox.fr
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/core.c

index e740f7ef0485e25cb05d7595acd2d2453ba6d544..9fcb9d913556adb9523eb91425230229666201b8 100644 (file)
@@ -1670,6 +1670,7 @@ static int pinctrl_pins_show(struct seq_file *s, void *what)
                seq_printf(s, "pin %d (%s) ", pin, desc->name);
 
 #ifdef CONFIG_GPIOLIB
+               gdev = NULL;
                gpio_num = -1;
                list_for_each_entry(range, &pctldev->gpio_ranges, node) {
                        if (range->pins != NULL) {