unit-tests: Add more tests for proposal creation

diff --git a/src/libcharon/tests/suites/test_proposal.c b/src/libcharon/tests/suites/test_proposal.c
index f5bf9440ad948ef7e8ec25085fd14923855b33aa..19f4cd1e1980044f6e3c166093925cdd5de35d5d 100644 (file)
--- a/src/libcharon/tests/suites/test_proposal.c
+++ b/src/libcharon/tests/suites/test_proposal.c
@@ -17,6 +17,64 @@
 
 #include <config/proposal.h>
 
+static struct {
+       protocol_id_t proto;
+       char *proposal;
+       char *expected;
+} create_data[] = {
+       { PROTO_IKE, "", NULL },
+       { PROTO_IKE, "sha256", NULL },
+       { PROTO_IKE, "sha256-modp3072", NULL },
+       { PROTO_IKE, "null-sha256-modp3072", "IKE:NULL/HMAC_SHA2_256_128/PRF_HMAC_SHA2_256/MODP_3072" },
+       { PROTO_IKE, "aes128", NULL },
+       { PROTO_IKE, "aes128-sha256", NULL },
+       { PROTO_IKE, "aes128-sha256-modpnone", NULL },
+       { PROTO_IKE, "aes128-sha256-modp3072", "IKE:AES_CBC_128/HMAC_SHA2_256_128/PRF_HMAC_SHA2_256/MODP_3072" },
+       { PROTO_IKE, "aes128-sha256-prfsha384-modp3072", "IKE:AES_CBC_128/HMAC_SHA2_256_128/PRF_HMAC_SHA2_384/MODP_3072" },
+       { PROTO_IKE, "aes128gcm16-modp3072", NULL },
+       { PROTO_IKE, "aes128gcm16-prfsha256-modp3072", "IKE:AES_GCM_16_128/PRF_HMAC_SHA2_256/MODP_3072" },
+       { PROTO_IKE, "aes128gcm16-sha256-modp3072", "IKE:AES_GCM_16_128/PRF_HMAC_SHA2_256/MODP_3072" },
+       { PROTO_IKE, "aes128gcm16-aes128-modp3072", NULL },
+       { PROTO_IKE, "aes128gcm16-aes128-sha256-modp3072", NULL },
+       { PROTO_ESP, "", NULL },
+       { PROTO_ESP, "sha256", NULL },
+       { PROTO_ESP, "aes128-sha256", "ESP:AES_CBC_128/HMAC_SHA2_256_128/NO_EXT_SEQ" },
+       { PROTO_ESP, "aes128-sha256-esn", "ESP:AES_CBC_128/HMAC_SHA2_256_128/EXT_SEQ" },
+       { PROTO_ESP, "aes128-sha256-noesn", "ESP:AES_CBC_128/HMAC_SHA2_256_128/NO_EXT_SEQ" },
+       { PROTO_ESP, "aes128-sha256-esn-noesn", "ESP:AES_CBC_128/HMAC_SHA2_256_128/EXT_SEQ/NO_EXT_SEQ" },
+       { PROTO_ESP, "aes128-sha256-prfsha256-modp3072", "ESP:AES_CBC_128/HMAC_SHA2_256_128/MODP_3072/NO_EXT_SEQ" },
+       { PROTO_ESP, "aes128gcm16-aes128-sha256-modp3072", NULL },
+       { PROTO_ESP, "aes128gmac", "ESP:NULL_AES_GMAC_128/NO_EXT_SEQ" },
+       { PROTO_AH,  "", NULL },
+       { PROTO_AH,  "aes128", NULL },
+       { PROTO_AH,  "aes128-sha256", "AH:HMAC_SHA2_256_128/NO_EXT_SEQ" },
+       { PROTO_AH,  "sha256-sha1", "AH:HMAC_SHA2_256_128/HMAC_SHA1_96/NO_EXT_SEQ" },
+       { PROTO_AH,  "aes128gmac-sha256", "AH:AES_128_GMAC/HMAC_SHA2_256_128/NO_EXT_SEQ" },
+       { PROTO_AH,  "aes128gmac-sha256-prfsha256", "AH:AES_128_GMAC/HMAC_SHA2_256_128/NO_EXT_SEQ" },
+       { PROTO_AH,  "aes128gmac-aes256gmac-aes128-sha256", "AH:AES_128_GMAC/AES_256_GMAC/HMAC_SHA2_256_128/NO_EXT_SEQ" },
+       { PROTO_AH,  "sha256-esn", "AH:HMAC_SHA2_256_128/EXT_SEQ" },
+       { PROTO_AH,  "sha256-noesn", "AH:HMAC_SHA2_256_128/NO_EXT_SEQ" },
+       { PROTO_AH,  "sha256-esn-noesn", "AH:HMAC_SHA2_256_128/EXT_SEQ/NO_EXT_SEQ" },
+};
+
+START_TEST(test_create_from_string)
+{
+       proposal_t *proposal;
+       char str[BUF_LEN];
+
+       proposal = proposal_create_from_string(create_data[_i].proto,
+                                                                                  create_data[_i].proposal);
+       if (!create_data[_i].expected)
+       {
+               ck_assert(!proposal);
+               return;
+       }
+       snprintf(str, sizeof(str), "%P", proposal);
+       ck_assert_str_eq(create_data[_i].expected, str);
+       proposal->destroy(proposal);
+}
+END_TEST
+
 static struct {
        protocol_id_t proto;
        char *self;
@@ -37,9 +95,6 @@ static struct {
        { PROTO_ESP, "aes128-sha256", "aes128-sha256-modp3072-modpnone", "aes128-sha256" },
        { PROTO_ESP, "aes128-sha256-modp3072-modpnone", "aes128-sha256-modpnone-modp3072", "aes128-sha256-modp3072" },
        { PROTO_ESP, "aes128-sha256-modpnone-modp3072", "aes128-sha256-modp3072-modpnone", "aes128-sha256-modpnone" },
-       { PROTO_IKE, "aes128", NULL, NULL },
-       { PROTO_IKE, "aes128-sha256", NULL, NULL },
-       { PROTO_IKE, "aes128-sha256-modpnone", NULL, NULL },
        { PROTO_IKE, "aes128-sha256-modp3072", "aes128-sha256-modp3072", "aes128-sha256-modp3072" },
        { PROTO_IKE, "aes128-sha256-modp3072", "aes128-sha256-modp3072-modpnone", "aes128-sha256-modp3072" },
        { PROTO_IKE, "aes128-sha256-modp3072-modpnone", "aes128-sha256-modp3072", "aes128-sha256-modp3072" },
@@ -51,11 +106,6 @@ START_TEST(test_select)
 
        self = proposal_create_from_string(select_data[_i].proto,
                                                                           select_data[_i].self);
-       if (!select_data[_i].other)
-       {
-               ck_assert(!self);
-               return;
-       }
        other = proposal_create_from_string(select_data[_i].proto,
                                                                                select_data[_i].other);
        selected = self->select(self, other, FALSE);
@@ -85,6 +135,10 @@ Suite *proposal_suite_create()
 
        s = suite_create("proposal");
 
+       tc = tcase_create("create_from_string");
+       tcase_add_loop_test(tc, test_create_from_string, 0, countof(create_data));
+       suite_add_tcase(s, tc);
+
        tc = tcase_create("select");
        tcase_add_loop_test(tc, test_select, 0, countof(select_data));
        suite_add_tcase(s, tc);