]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpiolib: cdev: remove redundant store of debounce_period_us
authorKent Gibson <warthog618@gmail.com>
Sun, 20 Oct 2024 11:52:38 +0000 (19:52 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 22 Oct 2024 07:15:30 +0000 (09:15 +0200)
debounce_setup() stores the debounce_period_us if the driver supports
debounce, but the debounce_period_us is also stored where debounce_setup()
is called, independent of whether the debounce is being perfomed by
hardware or software.

Remove the redundant storing of the debounce_period_us in
debounce_setup().

Signed-off-by: Kent Gibson <warthog618@gmail.com>
Link: https://lore.kernel.org/r/20241020115238.170994-1-warthog618@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpiolib-cdev.c

index 13d83675bf4f8fe7bf9fbe2bc89cc72dc01d053e..0ec162b0ea042476db6f44ebbaa70fcd594a5be2 100644 (file)
@@ -929,10 +929,6 @@ static int debounce_setup(struct line *line, unsigned int debounce_period_us)
        ret = gpio_do_set_config(line->desc,
                        pinconf_to_config_packed(PIN_CONFIG_INPUT_DEBOUNCE,
                                                 debounce_period_us));
-       if (!ret) {
-               WRITE_ONCE(line->desc->debounce_period_us, debounce_period_us);
-               return ret;
-       }
        if (ret != -ENOTSUPP)
                return ret;