badblocks: fix merge issue when new badblocks align with pre+1

There is a merge issue when adding badblocks as follow:
  echo 0 10 > bad_blocks
  echo 30 10 > bad_blocks
  echo 20 10 > bad_blocks
  cat bad_blocks
  0 10
  20 10    //should be merged with (30 10)
  30 10

In this case, if new badblocks does not intersect with prev, it is added
by insert_at(). If there is an intersection with prev+1, the merge will
be processed in the next re_insert loop.

However, when the end of the new badblocks is exactly equal to the offset
of prev+1, no further re_insert loop occurs, and the two badblocks are not
merge.

Fix it by inc prev, badblocks can be merged during the subsequent code.

Fixes: aa511ff8218b ("badblocks: switch to the improved badblock handling code")
Signed-off-by: Li Nan <linan122@huawei.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20250227075507.151331-9-zhengqixing@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/block/badblocks.c b/block/badblocks.c
index 57e9edf9b84879cafdd24a876ca503bc6d758b80..92bd43f7fff1fcec05aba2cb13550bce7e0dadbe 100644 (file)
--- a/block/badblocks.c
+++ b/block/badblocks.c
@@ -892,7 +892,7 @@ re_insert:
                len = insert_at(bb, 0, &bad);
                bb->count++;
                added++;
-               hint = 0;
+               hint = ++prev;
                goto update_sectors;
        }
 
@@ -947,7 +947,7 @@ re_insert:
        len = insert_at(bb, prev + 1, &bad);
        bb->count++;
        added++;
-       hint = prev + 1;
+       hint = ++prev;
 
 update_sectors:
        s += len;