]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Fortran: perform array subscript checks only for valid INTEGER bounds
authorHarald Anlauf <anlauf@gmx.de>
Tue, 7 Dec 2021 20:34:31 +0000 (21:34 +0100)
committerHarald Anlauf <anlauf@gmx.de>
Tue, 7 Dec 2021 22:16:18 +0000 (23:16 +0100)
gcc/fortran/ChangeLog:

PR fortran/103607
* frontend-passes.c (do_subscript): Ensure that array bounds are
of type INTEGER before performing checks on array subscripts.

gcc/testsuite/ChangeLog:

PR fortran/103607
* gfortran.dg/pr103607.f90: New test.

gcc/fortran/frontend-passes.c
gcc/testsuite/gfortran.dg/pr103607.f90 [new file with mode: 0644]

index 4764c834f4f2cecb8126881d6aa934973ad400b6..57b24a11cbefeb360329de5a04527b045c6b34f9 100644 (file)
@@ -2914,6 +2914,7 @@ do_subscript (gfc_expr **e)
                    {
                      if (ar->as->lower[i]
                          && ar->as->lower[i]->expr_type == EXPR_CONSTANT
+                         && ar->as->lower[i]->ts.type == BT_INTEGER
                          && mpz_cmp (val, ar->as->lower[i]->value.integer) < 0)
                        gfc_warning (warn, "Array reference at %L out of bounds "
                                     "(%ld < %ld) in loop beginning at %L",
@@ -2923,6 +2924,7 @@ do_subscript (gfc_expr **e)
 
                      if (ar->as->upper[i]
                          && ar->as->upper[i]->expr_type == EXPR_CONSTANT
+                         && ar->as->upper[i]->ts.type == BT_INTEGER
                          && mpz_cmp (val, ar->as->upper[i]->value.integer) > 0)
                            gfc_warning (warn, "Array reference at %L out of bounds "
                                         "(%ld > %ld) in loop beginning at %L",
@@ -2938,6 +2940,7 @@ do_subscript (gfc_expr **e)
                    {
                      if (ar->as->lower[i]
                          && ar->as->lower[i]->expr_type == EXPR_CONSTANT
+                         && ar->as->lower[i]->ts.type == BT_INTEGER
                          && mpz_cmp (val, ar->as->lower[i]->value.integer) < 0)
                        gfc_warning (warn, "Array reference at %L out of bounds "
                                     "(%ld < %ld) in loop beginning at %L",
@@ -2947,6 +2950,7 @@ do_subscript (gfc_expr **e)
 
                      if (ar->as->upper[i]
                          && ar->as->upper[i]->expr_type == EXPR_CONSTANT
+                         && ar->as->upper[i]->ts.type == BT_INTEGER
                          && mpz_cmp (val, ar->as->upper[i]->value.integer) > 0)
                        gfc_warning (warn, "Array reference at %L out of bounds "
                                     "(%ld > %ld) in loop beginning at %L",
diff --git a/gcc/testsuite/gfortran.dg/pr103607.f90 b/gcc/testsuite/gfortran.dg/pr103607.f90
new file mode 100644 (file)
index 0000000..a6a2c4f
--- /dev/null
@@ -0,0 +1,12 @@
+! { dg-do compile }
+! PR fortran/103607 - ICE in do_subscript, at fortran/frontend-passes.c:2927
+! Contributed by G.Steinmetz
+
+program p
+  integer :: i, x(abs(2.)) ! { dg-error "must be of INTEGER type" }
+  do i = 1, 2
+     x(i) = 0
+  end do
+end
+
+! { dg-prune-output "must have constant shape" }