]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
pinctrl: renesas: Use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Sun, 31 Aug 2025 08:49:58 +0000 (16:49 +0800)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 8 Sep 2025 10:03:08 +0000 (12:03 +0200)
Change the 'ret' variable in sh_pfc_pinconf_group_set() from unsigned
int to int, as it needs to store either negative error codes or zero
returned by sh_pfc_pinconf_set().

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Fixes: d0593c363f04ccc4 ("pinctrl: sh-pfc: Propagate errors on group config")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/20250831084958.431913-4-rongqianfeng@vivo.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/pinctrl/renesas/pinctrl.c

index 29d16c9c1bd194abaf8708cbc4199a6be9ed45e4..3a742f74ecd1dcdf6b7a286e8989b6b221860dbc 100644 (file)
@@ -726,7 +726,8 @@ static int sh_pfc_pinconf_group_set(struct pinctrl_dev *pctldev, unsigned group,
        struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
        const unsigned int *pins;
        unsigned int num_pins;
-       unsigned int i, ret;
+       unsigned int i;
+       int ret;
 
        pins = pmx->pfc->info->groups[group].pins;
        num_pins = pmx->pfc->info->groups[group].nr_pins;