]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: phy: fixed_phy: initialize the link status as up
authorHeiner Kallweit <hkallweit1@gmail.com>
Mon, 10 Nov 2025 21:20:26 +0000 (22:20 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 13 Nov 2025 14:20:30 +0000 (15:20 +0100)
All callers initialize the link status as up. This change is in line
with how of_phy_register_fixed_link() behaves.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/45f644e8-2292-4787-a27a-f69084c93218@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/phy/fixed_phy.c

index 9bd6937411e439d00cc89dcaffce9435975b7570..715f0356f895ff4244964d2127edd642edcf41f5 100644 (file)
@@ -174,13 +174,11 @@ struct phy_device *fixed_phy_register(const struct fixed_phy_status *status,
        }
 
        /* propagate the fixed link values to struct phy_device */
-       phy->link = status->link;
-       if (status->link) {
-               phy->speed = status->speed;
-               phy->duplex = status->duplex;
-               phy->pause = status->pause;
-               phy->asym_pause = status->asym_pause;
-       }
+       phy->link = 1;
+       phy->speed = status->speed;
+       phy->duplex = status->duplex;
+       phy->pause = status->pause;
+       phy->asym_pause = status->asym_pause;
 
        of_node_get(np);
        phy->mdio.dev.of_node = np;
@@ -224,7 +222,6 @@ EXPORT_SYMBOL_GPL(fixed_phy_register);
 struct phy_device *fixed_phy_register_100fd(void)
 {
        static const struct fixed_phy_status status = {
-               .link   = true,
                .speed  = SPEED_100,
                .duplex = DUPLEX_FULL,
        };