istream-file: Assert-crash if read() fails with EBADF.

Something's already wrong at that point and it may not be safe to continue.
Also crashing makes it easier to debug such situation.

diff --git a/src/lib/istream-file.c b/src/lib/istream-file.c
index 2d04106e852d7813a1d679bb9271e14a994f1580..c4dabd5402032d1adf821b84958948d83545a74a 100644 (file)
--- a/src/lib/istream-file.c
+++ b/src/lib/istream-file.c
@@ -94,6 +94,9 @@ static ssize_t i_stream_file_read(struct istream_private *stream)
                        ret = 0;
                } else {
                        i_assert(errno != 0);
+                       /* if we get EBADF for a valid fd, it means something's
+                          really wrong and we'd better just crash. */
+                       i_assert(errno != EBADF);
                        stream->istream.stream_errno = errno;
                        return -1;
                }