]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.4-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Oct 2016 10:16:50 +0000 (12:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Oct 2016 10:16:50 +0000 (12:16 +0200)
added patches:
ima-use-file_dentry.patch

queue-4.4/ima-use-file_dentry.patch [new file with mode: 0644]
queue-4.4/series

diff --git a/queue-4.4/ima-use-file_dentry.patch b/queue-4.4/ima-use-file_dentry.patch
new file mode 100644 (file)
index 0000000..586fe1f
--- /dev/null
@@ -0,0 +1,54 @@
+From e71b9dff0634edb127f449e076e883ef24a8c76c Mon Sep 17 00:00:00 2001
+From: Miklos Szeredi <mszeredi@redhat.com>
+Date: Fri, 16 Sep 2016 12:44:20 +0200
+Subject: ima: use file_dentry()
+
+From: Miklos Szeredi <mszeredi@redhat.com>
+
+commit e71b9dff0634edb127f449e076e883ef24a8c76c upstream.
+
+Ima tries to call ->setxattr() on overlayfs dentry after having locked
+underlying inode, which results in a deadlock.
+
+Reported-by: Krisztian Litkey <kli@iki.fi>
+Fixes: 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and f_inode to the underlay")
+Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
+Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ security/integrity/ima/ima_api.c      |    2 +-
+ security/integrity/ima/ima_appraise.c |    4 ++--
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+
+--- a/security/integrity/ima/ima_api.c
++++ b/security/integrity/ima/ima_api.c
+@@ -202,7 +202,7 @@ int ima_collect_measurement(struct integ
+       } hash;
+       if (xattr_value)
+-              *xattr_len = ima_read_xattr(file->f_path.dentry, xattr_value);
++              *xattr_len = ima_read_xattr(file_dentry(file), xattr_value);
+       if (!(iint->flags & IMA_COLLECTED)) {
+               u64 i_version = file_inode(file)->i_version;
+--- a/security/integrity/ima/ima_appraise.c
++++ b/security/integrity/ima/ima_appraise.c
+@@ -189,7 +189,7 @@ int ima_appraise_measurement(int func, s
+ {
+       static const char op[] = "appraise_data";
+       char *cause = "unknown";
+-      struct dentry *dentry = file->f_path.dentry;
++      struct dentry *dentry = file_dentry(file);
+       struct inode *inode = d_backing_inode(dentry);
+       enum integrity_status status = INTEGRITY_UNKNOWN;
+       int rc = xattr_len, hash_start = 0;
+@@ -289,7 +289,7 @@ out:
+  */
+ void ima_update_xattr(struct integrity_iint_cache *iint, struct file *file)
+ {
+-      struct dentry *dentry = file->f_path.dentry;
++      struct dentry *dentry = file_dentry(file);
+       int rc = 0;
+       /* do not collect and update hash for digital signatures */
index b60bdcf6e103b523c92830e81c3a9dbb7e458b04..ace0c2ef08a0b228cc9574b276033f4a95c76117 100644 (file)
@@ -16,3 +16,4 @@ x86-dumpstack-fix-x86_32-kernel_stack_pointer-previous-stack-access.patch
 arm-dts-mvebu-armada-390-add-missing-compatibility-string-and-bracket.patch
 arm-dts-msm8064-remove-flags-from-spmi-mpp-irqs.patch
 arm-cpuidle-fix-error-return-code.patch
+ima-use-file_dentry.patch