]> git.ipfire.org Git - thirdparty/Chart.js.git/commitdiff
Attempt to fix test flakiness (Firefox) (#4880)
authorBen McCann <benjamin.j.mccann@gmail.com>
Sun, 22 Oct 2017 15:32:39 +0000 (08:32 -0700)
committerSimon Brunel <simonbrunel@users.noreply.github.com>
Sun, 22 Oct 2017 15:32:39 +0000 (17:32 +0200)
These settings deal with browser disconnects. We had seen test flakiness from Firefox:
[Firefox 56.0.0 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms

karma.conf.js

index 3ef7f49bfa73daa68fc224a95be79f6f2f2f4820..5601cbd721219700cdb01d25b9895ed7d40cae45 100644 (file)
@@ -14,7 +14,13 @@ module.exports = function(karma) {
 
                browserify: {
                        debug: true
-               }
+               },
+
+               // These settings deal with browser disconnects. We had seen test flakiness from Firefox
+               // [Firefox 56.0.0 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms.
+               // https://github.com/jasmine/jasmine/issues/1327#issuecomment-332939551
+               browserNoActivityTimeout: 60000,
+               browserDisconnectTolerance: 3
        };
 
        // https://swizec.com/blog/how-to-run-javascript-tests-in-chrome-on-travis/swizec/6647