]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i2c: iproc: Replace udelay() with usleep_range()
authorAndi Shyti <andi.shyti@kernel.org>
Fri, 18 Apr 2025 21:16:31 +0000 (23:16 +0200)
committerAndi Shyti <andi@smida.it>
Mon, 19 May 2025 20:23:56 +0000 (22:23 +0200)
Replace udelay(100) with usleep_range(100, 200) as recommended
by kernel documentation. The delay is not in atomic context, so
busy-waiting is unnecessary.

Also update the comment for clarity.

Link: https://lore.kernel.org/r/20250418211635.2666234-7-andi.shyti@kernel.org
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-bcm-iproc.c

index 44083698121a4e47bb04339131205c9ef30434bd..2e04ea157e8e5d732a0fadf8bbd75847b779d654 100644 (file)
@@ -276,8 +276,8 @@ static void bcm_iproc_i2c_slave_init(
                val |= BIT(CFG_RESET_SHIFT);
                iproc_i2c_wr_reg(iproc_i2c, CFG_OFFSET, val);
 
-               /* wait 100 usec per spec */
-               udelay(100);
+               /* wait approximately 100 usec as per spec */
+               usleep_range(100, 200);
 
                /* bring controller out of reset */
                val &= ~(BIT(CFG_RESET_SHIFT));
@@ -687,8 +687,8 @@ static void bcm_iproc_i2c_init(struct bcm_iproc_i2c_dev *iproc_i2c)
        val &= ~(BIT(CFG_EN_SHIFT));
        iproc_i2c_wr_reg(iproc_i2c, CFG_OFFSET, val);
 
-       /* wait 100 usec per spec */
-       udelay(100);
+       /* wait approximately 100 usec as per spec */
+       usleep_range(100, 200);
 
        /* bring controller out of reset */
        val &= ~(BIT(CFG_RESET_SHIFT));