]> git.ipfire.org Git - thirdparty/libarchive.git/commitdiff
archive_read.c: remove unnecessary comparsion (iindex is unsigned int)
authorMartin Matuska <martin@matuska.org>
Thu, 16 Jan 2020 23:31:07 +0000 (00:31 +0100)
committerMartin Matuska <martin@matuska.org>
Thu, 16 Jan 2020 23:31:07 +0000 (00:31 +0100)
Found by LGTM.com code analysis

libarchive/archive_read.c

index 5872601101ba60dcd95c1fe3d210743b01dad98c..4a933b2fc084dc2ac71b4cf9a5d893f3321ea52e 100644 (file)
@@ -433,7 +433,7 @@ archive_read_add_callback_data(struct archive *_a, void *client_data,
                return ARCHIVE_FATAL;
        }
        a->client.dataset = (struct archive_read_data_node *)p;
-       for (i = a->client.nodes - 1; i > iindex && i > 0; i--) {
+       for (i = a->client.nodes - 1; i > iindex; i--) {
                a->client.dataset[i].data = a->client.dataset[i-1].data;
                a->client.dataset[i].begin_position = -1;
                a->client.dataset[i].total_size = -1;