]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: typec: tcpm: Switch to use hrtimer_setup()
authorNam Cao <namcao@linutronix.de>
Wed, 5 Feb 2025 10:45:55 +0000 (11:45 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 18 Feb 2025 10:19:02 +0000 (11:19 +0100)
hrtimer_setup() takes the callback function pointer as argument and
initializes the timer completely.

Replace hrtimer_init() and the open coded initialization of
hrtimer::function with the new setup mechanism.

Patch was created by using Coccinelle.

Signed-off-by: Nam Cao <namcao@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Zack Rusin <zack.rusin@broadcom.com>
Link: https://lore.kernel.org/all/7fd2a1f72b3833e1fb36f56f2b28a08c1e64f47e.1738746904.git.namcao@linutronix.de
drivers/usb/typec/tcpm/tcpm.c

index 6bf1a22c785aff6b1ad77a20d85e22580527f5b1..9c455f0732330424e75e5627ce0c97b1fc91c23a 100644 (file)
@@ -7721,14 +7721,14 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)
        kthread_init_work(&port->event_work, tcpm_pd_event_handler);
        kthread_init_work(&port->enable_frs, tcpm_enable_frs_work);
        kthread_init_work(&port->send_discover_work, tcpm_send_discover_work);
-       hrtimer_init(&port->state_machine_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
-       port->state_machine_timer.function = state_machine_timer_handler;
-       hrtimer_init(&port->vdm_state_machine_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
-       port->vdm_state_machine_timer.function = vdm_state_machine_timer_handler;
-       hrtimer_init(&port->enable_frs_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
-       port->enable_frs_timer.function = enable_frs_timer_handler;
-       hrtimer_init(&port->send_discover_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
-       port->send_discover_timer.function = send_discover_timer_handler;
+       hrtimer_setup(&port->state_machine_timer, state_machine_timer_handler, CLOCK_MONOTONIC,
+                     HRTIMER_MODE_REL);
+       hrtimer_setup(&port->vdm_state_machine_timer, vdm_state_machine_timer_handler,
+                     CLOCK_MONOTONIC, HRTIMER_MODE_REL);
+       hrtimer_setup(&port->enable_frs_timer, enable_frs_timer_handler, CLOCK_MONOTONIC,
+                     HRTIMER_MODE_REL);
+       hrtimer_setup(&port->send_discover_timer, send_discover_timer_handler, CLOCK_MONOTONIC,
+                     HRTIMER_MODE_REL);
 
        spin_lock_init(&port->pd_event_lock);