]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: Apply Miod's suggestion
authorRemi Gacogne <remi.gacogne@powerdns.com>
Fri, 22 Aug 2025 12:38:03 +0000 (14:38 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Fri, 5 Sep 2025 13:13:25 +0000 (15:13 +0200)
Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Remi Gacogne <github@coredump.fr>
(cherry picked from commit 0cf2668a8c625f72944f682010befbe3089b9dd0)

pdns/dnsdistdist/dnsdist-nghttp2-in.cc

index b200c9adb71a64905b75d292be51664a3060e292..2681d880d6bffa76387601f58879399e316ff206 100644 (file)
@@ -549,7 +549,7 @@ static const std::string s_xForwardedForHeaderName("x-forwarded-for");
 
 static void addHeader(std::vector<nghttp2_nv>& headers, const std::string_view& name, bool nameIsStatic, const std::string_view& value, bool valueIsStatic)
 {
-  /* Be careful when setting NGHTTP2_NV_FLAG_NO_COPY_NAME or NGHTTP2_NV_FLAG_NO_COPY_VALUE, the corresponding name or value needs to exist until after nghttp2_session_send() has been called, not just nghttp2_submit_response */
+  /* Be careful when setting NGHTTP2_NV_FLAG_NO_COPY_NAME or NGHTTP2_NV_FLAG_NO_COPY_VALUE, the corresponding name or value needs to exist until after nghttp2_session_send() has been called, not just nghttp2_submit_response(). */
   uint8_t flag{NGHTTP2_NV_FLAG_NONE};
   if (nameIsStatic) {
     flag |= NGHTTP2_NV_FLAG_NO_COPY_NAME;