]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities
authorDaniel Golle <daniel@makrotopia.org>
Thu, 2 Jan 2025 12:41:21 +0000 (12:41 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 4 Jan 2025 16:21:52 +0000 (08:21 -0800)
Neither does the LynxI PCS support QSGMII, nor is in-band-status supported
in 2500Base-X mode. Fix the pcs_inband_caps() method accordingly.

Fixes: 520d29bdda86 ("net: pcs: pcs-mtk-lynxi: implement pcs_inband_caps() method")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: https://patch.msgid.link/Z3aJccb1vW14aukg@pidgin.makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/pcs/pcs-mtk-lynxi.c

index 7de8045352298b0de91436d132102695b433237b..ed91cd7a406ae3f74ee5061280411a5f8ba1730d 100644 (file)
@@ -93,11 +93,12 @@ static unsigned int mtk_pcs_lynxi_inband_caps(struct phylink_pcs *pcs,
 {
        switch (interface) {
        case PHY_INTERFACE_MODE_1000BASEX:
-       case PHY_INTERFACE_MODE_2500BASEX:
        case PHY_INTERFACE_MODE_SGMII:
-       case PHY_INTERFACE_MODE_QSGMII:
                return LINK_INBAND_DISABLE | LINK_INBAND_ENABLE;
 
+       case PHY_INTERFACE_MODE_2500BASEX:
+               return LINK_INBAND_DISABLE;
+
        default:
                return 0;
        }