]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
i3c: mipi-i3c-hci: Remove function enter DBG() printouts
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Wed, 27 Aug 2025 10:30:08 +0000 (13:30 +0300)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 16 Sep 2025 15:06:42 +0000 (17:06 +0200)
These function enter DBG("") printouts are not very useful in error
report point of view because they require code recompile. In which case
they can be replaced with more informative debug prints if needed so
remove them for now.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Link: https://lore.kernel.org/r/20250827103009.243771-5-jarkko.nikula@linux.intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master/mipi-i3c-hci/core.c

index d532933ac7ab01981af8bd0cce3661d6d9aee47a..9932945ecf06d7b94c720a9b8b2e8856d1bdb4ff 100644 (file)
@@ -121,8 +121,6 @@ static int i3c_hci_bus_init(struct i3c_master_controller *m)
        struct i3c_device_info info;
        int ret;
 
-       DBG("");
-
        if (hci->cmd == &mipi_i3c_hci_cmd_v1) {
                ret = mipi_i3c_hci_dat_v1.init(hci);
                if (ret)
@@ -159,8 +157,6 @@ static void i3c_hci_bus_cleanup(struct i3c_master_controller *m)
        struct i3c_hci *hci = to_i3c_hci(m);
        struct platform_device *pdev = to_platform_device(m->dev.parent);
 
-       DBG("");
-
        reg_clear(HC_CONTROL, HC_CONTROL_BUS_ENABLE);
        synchronize_irq(platform_get_irq(pdev, 0));
        hci->io->cleanup(hci);
@@ -267,8 +263,6 @@ static int i3c_hci_daa(struct i3c_master_controller *m)
 {
        struct i3c_hci *hci = to_i3c_hci(m);
 
-       DBG("");
-
        return hci->cmd->perform_daa(hci);
 }
 
@@ -385,8 +379,6 @@ static int i3c_hci_attach_i3c_dev(struct i3c_dev_desc *dev)
        struct i3c_hci_dev_data *dev_data;
        int ret;
 
-       DBG("");
-
        dev_data = kzalloc(sizeof(*dev_data), GFP_KERNEL);
        if (!dev_data)
                return -ENOMEM;
@@ -410,8 +402,6 @@ static int i3c_hci_reattach_i3c_dev(struct i3c_dev_desc *dev, u8 old_dyn_addr)
        struct i3c_hci *hci = to_i3c_hci(m);
        struct i3c_hci_dev_data *dev_data = i3c_dev_get_master_data(dev);
 
-       DBG("");
-
        if (hci->cmd == &mipi_i3c_hci_cmd_v1)
                mipi_i3c_hci_dat_v1.set_dynamic_addr(hci, dev_data->dat_idx,
                                             dev->info.dyn_addr);
@@ -424,8 +414,6 @@ static void i3c_hci_detach_i3c_dev(struct i3c_dev_desc *dev)
        struct i3c_hci *hci = to_i3c_hci(m);
        struct i3c_hci_dev_data *dev_data = i3c_dev_get_master_data(dev);
 
-       DBG("");
-
        i3c_dev_set_master_data(dev, NULL);
        if (hci->cmd == &mipi_i3c_hci_cmd_v1)
                mipi_i3c_hci_dat_v1.free_entry(hci, dev_data->dat_idx);
@@ -439,8 +427,6 @@ static int i3c_hci_attach_i2c_dev(struct i2c_dev_desc *dev)
        struct i3c_hci_dev_data *dev_data;
        int ret;
 
-       DBG("");
-
        if (hci->cmd != &mipi_i3c_hci_cmd_v1)
                return 0;
        dev_data = kzalloc(sizeof(*dev_data), GFP_KERNEL);
@@ -464,8 +450,6 @@ static void i3c_hci_detach_i2c_dev(struct i2c_dev_desc *dev)
        struct i3c_hci *hci = to_i3c_hci(m);
        struct i3c_hci_dev_data *dev_data = i2c_dev_get_master_data(dev);
 
-       DBG("");
-
        if (dev_data) {
                i2c_dev_set_master_data(dev, NULL);
                if (hci->cmd == &mipi_i3c_hci_cmd_v1)