]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mmc: sdhci-xenon: use modern PM macros
authorJisheng Zhang <jszhang@kernel.org>
Fri, 15 Aug 2025 01:33:38 +0000 (09:33 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 22 Aug 2025 10:14:03 +0000 (12:14 +0200)
Use the modern PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Link: https://lore.kernel.org/r/20250815013413.28641-4-jszhang@kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-xenon.c

index b12bee8342bdd5d37d8fb8019bfe8e3630baef1f..046e8100dd0899f393c6ce0277e71b3890c631d7 100644 (file)
@@ -622,7 +622,6 @@ static void xenon_remove(struct platform_device *pdev)
        clk_disable_unprepare(pltfm_host->clk);
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int xenon_suspend(struct device *dev)
 {
        struct sdhci_host *host = dev_get_drvdata(dev);
@@ -635,9 +634,7 @@ static int xenon_suspend(struct device *dev)
        priv->restore_needed = true;
        return ret;
 }
-#endif
 
-#ifdef CONFIG_PM
 static int xenon_runtime_suspend(struct device *dev)
 {
        struct sdhci_host *host = dev_get_drvdata(dev);
@@ -685,14 +682,10 @@ out:
        clk_disable_unprepare(pltfm_host->clk);
        return ret;
 }
-#endif /* CONFIG_PM */
 
 static const struct dev_pm_ops sdhci_xenon_dev_pm_ops = {
-       SET_SYSTEM_SLEEP_PM_OPS(xenon_suspend,
-                               pm_runtime_force_resume)
-       SET_RUNTIME_PM_OPS(xenon_runtime_suspend,
-                          xenon_runtime_resume,
-                          NULL)
+       SYSTEM_SLEEP_PM_OPS(xenon_suspend, pm_runtime_force_resume)
+       RUNTIME_PM_OPS(xenon_runtime_suspend, xenon_runtime_resume, NULL)
 };
 
 static const struct of_device_id sdhci_xenon_dt_ids[] = {
@@ -721,7 +714,7 @@ static struct platform_driver sdhci_xenon_driver = {
                .probe_type = PROBE_PREFER_ASYNCHRONOUS,
                .of_match_table = sdhci_xenon_dt_ids,
                .acpi_match_table = ACPI_PTR(sdhci_xenon_acpi_ids),
-               .pm = &sdhci_xenon_dev_pm_ops,
+               .pm = pm_ptr(&sdhci_xenon_dev_pm_ops),
        },
        .probe  = xenon_probe,
        .remove = xenon_remove,