]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
virtio_config: clarify output parameters
authorAlyssa Ross <hi@alyssa.is>
Fri, 29 Aug 2025 15:09:44 +0000 (17:09 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 21 Sep 2025 21:44:20 +0000 (17:44 -0400)
This was ambiguous enough for a broken patch (206cc44588f7 ("virtio:
reject shm region if length is zero")) to make it into the kernel, so
make it clearer.

Link: https://lore.kernel.org/r/20250816071600-mutt-send-email-mst@kernel.org/
Signed-off-by: Alyssa Ross <hi@alyssa.is>
Message-Id: <20250829150944.233505-1-hi@alyssa.is>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
include/linux/virtio_config.h

index 8bf156dde554a5a6afb474fcbb9ec72191b5658f..7427b79d6f3d544b685d5684407b1f7b6c9e23f0 100644 (file)
@@ -193,14 +193,15 @@ static inline bool virtio_has_feature(const struct virtio_device *vdev,
 }
 
 static inline void virtio_get_features(struct virtio_device *vdev,
-                                      u64 *features)
+                                      u64 *features_out)
 {
        if (vdev->config->get_extended_features) {
-               vdev->config->get_extended_features(vdev, features);
+               vdev->config->get_extended_features(vdev, features_out);
                return;
        }
 
-       virtio_features_from_u64(features, vdev->config->get_features(vdev));
+       virtio_features_from_u64(features_out,
+               vdev->config->get_features(vdev));
 }
 
 /**
@@ -326,11 +327,11 @@ int virtqueue_set_affinity(struct virtqueue *vq, const struct cpumask *cpu_mask)
 
 static inline
 bool virtio_get_shm_region(struct virtio_device *vdev,
-                          struct virtio_shm_region *region, u8 id)
+                          struct virtio_shm_region *region_out, u8 id)
 {
        if (!vdev->config->get_shm_region)
                return false;
-       return vdev->config->get_shm_region(vdev, region, id);
+       return vdev->config->get_shm_region(vdev, region_out, id);
 }
 
 static inline bool virtio_is_little_endian(struct virtio_device *vdev)